Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CURL or WGET in official image to enable health-check #5760

Closed
ysslang opened this issue Apr 10, 2021 · 5 comments · Fixed by #6680
Closed

No CURL or WGET in official image to enable health-check #5760

ysslang opened this issue Apr 10, 2021 · 5 comments · Fixed by #6680
Labels
bug Something isn't working stale Stale and will be closed if no activity occurs

Comments

@ysslang
Copy link

ysslang commented Apr 10, 2021

Describe the bug
There is a health-check api in jellyfin. However, it seems we can't check the status with official docker image.

System (please complete the following information):

  • Virtualization: Docker
  • Jellyfin Version: Docker latest image, 20210322

Expected behavior
Add curl or wget package to official docker image.

@ysslang ysslang added the bug Something isn't working label Apr 10, 2021
@cocool97
Copy link
Contributor

I added a PR to keep wget in image, but when would you need to debug with wget from inside the docker image and not from outside ?

@Shadowghost
Copy link
Contributor

Shadowghost commented Apr 12, 2021

We discussed this internally too because of the mentioned healthcheck endpoint (we'd really like to add this to the container). The problem that came up is the healt-check endpoint depending on the baseURL which is dynamically configured. We can't fix this without breaking current setups, so it'll most likely be a Jellyfin 11 thing.

Aside from the healtcheck I don't see any additional gain from including wget or curl into the images.

@ysslang
Copy link
Author

ysslang commented Apr 13, 2021

We discussed this interally too because of the mentioned healthcheck endpoint (we'd really like to add this to the container). The problem that came up is the healt-check endpoint depending on the baseURL which is dynamically configured. We can't fix this without breaking current setups, so it'll most likely be a Jellyfin 11 thing.

Aside from the healtcheck I don't see any additional gain from including wget or curl into the images.

Thanks.
The purpose of healthcheck within container is restarting container while jellyfin crash. Since my host is a low end vps.

@MarcelCoding
Copy link
Contributor

MarcelCoding commented Jun 1, 2021

This command is capable to extract the base path and port from the config files:

curl http://localhost:$(grep -oP '(?<=PublicPort>)[^<]+' /config/config/network.xml)/$(grep -oP '(?<=BaseUrl>)[^<]+' /config/config/network.xml)health

@stale
Copy link

stale bot commented Oct 2, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Stale and will be closed if no activity occurs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants