Call TMDb Person API with metadata language #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
May 12, 2021
deltonio2
approved these changes
May 13, 2021
Bond-009
approved these changes
May 15, 2021
MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonImageProvider.cs
Outdated
Show resolved
Hide resolved
Bond-009
approved these changes
May 18, 2021
| @@ -49,20 +48,20 @@ public IEnumerable<ImageType> GetSupportedImages(BaseItem item) | |||
| public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, CancellationToken cancellationToken) | |||
| { | |||
| var person = (Person)item; | |||
| var language = item.GetPreferredMetadataLanguage(); | |||
There was a problem hiding this comment.
Move to line 57, no need to call this if we do an early return
Bond-009
approved these changes
May 20, 2021
jellyfin-bot
added
the
merge conflict
jellyfin-bot
removed
the
merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Persons always had their English biography instead of the localized one.
I also changed the
NormalizeLanguagemethod because the TMDb API doesn't support de-CH, fr-CH and it-CH, so it now uses the language without the country code.Issues
Fixes #6015