Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property based testing #6150

Merged
merged 2 commits into from Jun 7, 2021
Merged

Add property based testing #6150

merged 2 commits into from Jun 7, 2021

Conversation

Bond-009
Copy link
Member

@Bond-009 Bond-009 commented Jun 5, 2021

No description provided.

@@ -17,7 +17,7 @@ public static string FirstToUpper(string str)
return str;
}

if (char.IsUpper(str[0]))
if (!char.IsLower(str[0]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my ignorance - but why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore - saw the comment in the test - might be worth putting it here as well.

@cvium cvium merged commit 1c6bf16 into jellyfin:master Jun 7, 2021
@Bond-009 Bond-009 deleted the proptest branch June 7, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants