Refactor GetResolutionText

[heyhippari]

Changes

This improves GetResolutionText a little by making it easier to read and better parsing resolutions (Also adding a few new ones like PAL resolutions and 8K).

Issues

[Bond-009]

Even tho you won't find any movies in 2560x1080, I still think this should handle it correctly

[heyhippari]

Even tho you won't find any movies in 2560x1080, I still think this should handle it correctly

But what would you put it as? It's not 1080p/1080i, which is widely understood to be 1920x1080 at most.

[Bond-009]

Not sure what "widely understood" means here, but wikipedia doesn't think so https://en.wikipedia.org/wiki/1080p#Resolutions

[heyhippari]

For the average consumer, 1080p means "Full HD", which is 1920x1080. 2560x1080 is a monitor resolution, not really a video one.

Imo, this should be limited to actual common video resolutions, otherwise we may as well simply return a string of width x height instead of doing this.

[Maxr1998]

Wouldn't it theoretically be the best to match by height first and then width? Should make the code more robust to uncommon resolutions, especially since the text normally describes the vertical/smaller resolution. .

EDIT: well, 1920x800/808 would be matched incorrectly then, so maybe that also doesn't fit perfectly.

[heyhippari]

Wouldn't it theoretically be the best to match by height first and then width? Should make the code more robust to uncommon resolutions, especially since the text normally describes the vertical/smaller resolution. .

EDIT: well, 1920x800/808 would be matched incorrectly then, so maybe that also doesn't fit perfectly.

You usually match by width, because that's the most consistent.

With black bars being cutoff quite often, matching by height is inconsistent and prone to errors.

At worst, the width gets 4-6 pixels cut off.

This way also allows you to properly match 1080p at 4:3 to the proper resolution.