Fix MediaBrowsers.Providers analysis issues #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richlander
changed the title
|
Thank you for the PR. If you continue making these fixes, please split the PR up into parts so reviewing is easier |
|
How would you like me to do that? Like 20 fixes at a time or number of files? |
|
How I typically organize it is to remove x number of warnings, each warning in a commit see #6281 for example |
|
Oh, I see. I never thought about doing it that way. I see I have 24 more errors to fix for the build to pass. If it's OK, I'll do fix those, and then switch to your approach for the next one. |
|
That works for me, thanks again |
crobibero
approved these changes
Jul 23, 2021
barronpm
approved these changes
Jul 26, 2021
jellyfin-bot
added
the
merge conflict
jellyfin-bot
removed
the
merge conflict
Bond-009
requested changes
Aug 6, 2021
MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bond-009 <bond.009@outlook.com>
|
I believe I resolved the outstanding feedback. Thanks! |
Bond-009
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves all analysis issues for MediaBrowsers.Providers project.
Supports #2149