Allow zero activity log retention days #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvium
approved these changes
Sep 2, 2021
carif
approved these changes
Sep 2, 2021
neilsb
approved these changes
Sep 2, 2021
crobibero
approved these changes
Sep 2, 2021
Bond-009
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The error message states that "Activity Log Retention days must be at least 0", but it fails with a value of zero, despite the message. This PR allows a value of 0.
A value of 0 is useful because it allows clearing the entire activity log through the "Clean Activity Log" task.
Issues
This is somewhat related to https://features.jellyfin.org/posts/1161/disable-or-anonymize-activity-logs