Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFCore improvements and cleanups #6522

Merged
merged 6 commits into from Sep 7, 2021
Merged

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented Sep 6, 2021

This PR cherrypicks some of the changes made in #6049 in order to ease the review:

  • Remove all the unused usings in the solution (we might want to enforce not unused usings to avoid having this situation again)
  • Logs EFcore migrations, so users are aware of them
  • Uses appHost instead of creating a new context in Program.cs
  • (Not in EFCore Image model update and cleanup #6049) Decouples model configuration into its own separate classes, so they're easier to maintain and doesn't clog the JellyfinDb.cs file

Jellyfin.Server.Implementations/JellyfinDb.cs Outdated Show resolved Hide resolved
@cvium cvium merged commit c794e48 into jellyfin:master Sep 7, 2021
@ferferga ferferga deleted the efcore-improvements branch September 7, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants