Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ombi auth through Jellyfin #6822

Merged
merged 3 commits into from Nov 13, 2021
Merged

Fix Ombi auth through Jellyfin #6822

merged 3 commits into from Nov 13, 2021

Conversation

NickSica
Copy link
Contributor

Changes
Adds a check for null or whitespace so the correct DeviceId, Version, and Device don't get overwritten

Issues
#6821

Co-authored-by: Cody Robibero <cody@robibe.ro>
@github-actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /DisplayPreferences/{displayPreferencesId}
Return Type:

Changed response : 200 OK

Display preferences retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property CustomPrefs (object)

Gets or sets the custom prefs.

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property CustomPrefs (object)

Gets or sets the custom prefs.

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property CustomPrefs (object)

Gets or sets the custom prefs.

POST /DisplayPreferences/{displayPreferencesId}
Request:

Changed content type : application/json

Updated DisplayPreferencesDto :

  • Changed property CustomPrefs (object)

Gets or sets the custom prefs.

Changed content type : text/json

Updated DisplayPreferencesDto :

  • Changed property CustomPrefs (object)

Gets or sets the custom prefs.

Changed content type : application/*+json

Updated DisplayPreferencesDto :

  • Changed property CustomPrefs (object)

Gets or sets the custom prefs.

Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this won't fully solve the issue you ran into, it's still a good change

@crobibero crobibero merged commit 8868b34 into jellyfin:master Nov 13, 2021
@crobibero crobibero mentioned this pull request Dec 20, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants