Refactor and extend external subtitle and audio handling #7255

Shadowghost · 2022-01-27T13:36:09Z

First time doing C# things, so any input is welcome.

This PR aims to add more support to the external media resolvers for subtitles and audio.

Changes

Merge the providers for external streams into one generic provider
Add support for forced and default flags based on what the (external) container (e.g. mka, mks) provides
Add container (e.g. mks, mka) support
Preserve Title of streams for external audio and subtitles if present, otherwise try to parse it from the filename
Use intermediate path resolvers to check file validity and flags based on namingOptions and extract language from filename if present
Remove AddExternalSubtitleStreams (LibraryManager and ILibraryManager)
Add support for providing external subtitle and audio streams via InternalMetadataPath

Questions

The MediaInfo query on the subtitle file requires a DlnaProfileType but there wasn't one for subtitles, so I added one. I'm not sure if this is the correct approach
LibraryManager exposed a method to explicitly add a subtitle stream. It wasn't used anywhere and I had problems properly keeping its functionality, so I removed it. If it should be kept I may need further assistance on how this can be achieved.

Supercedes: #7060
Fixes: #7057

PR to update docs: jellyfin-archive/jellyfin-docs#635

github-actions · 2022-01-27T13:38:17Z

Changes in OpenAPI specification found. Expand to see details.

What's Changed

`POST` /Dlna/Profiles

Request:

Changed content type : application/json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : text/json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : application/*+json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`GET` /Dlna/Profiles/{profileId}

Return Type:

Changed response : 200 OK

Device profile returned.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Dlna/Profiles/{profileId}

Request:

Changed content type : application/json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : text/json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : application/*+json

Updated DeviceProfile :

Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`GET` /Dlna/Profiles/Default

Return Type:

Changed response : 200 OK

Default device profile returned.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Items/{itemId}/PlaybackInfo

Request:

Changed content type : application/json

Updated PlaybackInfoDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : text/json

Updated PlaybackInfoDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : application/*+json

Updated PlaybackInfoDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /LiveStreams/Open

Request:

Changed content type : application/json

Updated OpenLiveStreamDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : text/json

Updated OpenLiveStreamDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : application/*+json

Updated OpenLiveStreamDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Sessions/Capabilities/Full

Request:

Changed content type : application/json

Updated ClientCapabilitiesDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : text/json

Updated ClientCapabilitiesDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle
Changed content type : application/*+json

Updated ClientCapabilitiesDto :

Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`GET` /Devices/Info

Return Type:

Changed response : 200 OK

Device info retrieved.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`GET` /Sessions

Return Type:

Changed response : 200 OK

List of sessions returned.

Changed content type : application/json

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`GET` /Devices

Return Type:

Changed response : 200 OK

Devices retrieved.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Users/{userId}/Authenticate

Return Type:

Changed response : 200 OK

User authenticated.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Users/AuthenticateByName

Return Type:

Changed response : 200 OK

User authenticated.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

`POST` /Users/AuthenticateWithQuickConnect

Return Type:

Changed response : 200 OK

User authenticated.

Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.

Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Updated DeviceProfile :
openapi-base openapi-changes.md openapi-head Changed property DirectPlayProfiles (array)

Gets or sets the direct play profiles.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Type (object)

Updated DlnaProfileType :
Added enum value:

openapi-base openapi-changes.md openapi-head Subtitle

MediaBrowser.Providers/MediaInfo/AudioResolver.cs

MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs

Emby.Naming/Audio/ExternalAudioFileInfo.cs

Emby.Naming/Subtitles/SubtitleFileInfo.cs

MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

tests/Jellyfin.Providers.Tests/MediaInfo/AudioResolverTests.cs

MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

Emby.Naming/ExternalFiles/ExternalPathParser.cs

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

MediaBrowser.Providers/MediaInfo/FFProbeProvider.cs

Emby.Naming/ExternalFiles/ExternalPathParserResult.cs

Emby.Naming/ExternalFiles/ExternalPathParser.cs

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

Emby.Naming/ExternalFiles/ExternalPathParser.cs

1337joe · 2022-02-17T16:44:53Z

Tests are failing because #7233 changed CultureDto to have a constructor instead of setters. You'll need to rebase on master to get the tests to fail locally.

…file recognition, consolidate and extend NamingOptions

Bond-009

It's not needed, just extra overhead

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

Co-authored-by: Bond-009 <bond.009@outlook.com>

Dnkhatri · 2022-02-27T12:47:09Z

After this pr was merged external subtitles are no longer being scanned and added to the database
@Shadowghost

Shadowghost · 2022-02-27T13:01:32Z

Please open an issue and include your file structure.

Dnkhatri · 2022-02-27T13:18:23Z

Please open an issue and include your file structure.

#7361

done

Shadowghost force-pushed the external-sub-audio branch 2 times, most recently from 9e0224b to f4fd390 Compare January 27, 2022 20:16

Shadowghost force-pushed the external-sub-audio branch from c1553dd to aed0afe Compare February 4, 2022 09:28

1337joe reviewed Feb 6, 2022

View reviewed changes

Shadowghost force-pushed the external-sub-audio branch 7 times, most recently from 76f3e45 to f2790b2 Compare February 9, 2022 12:30

1337joe requested changes Feb 12, 2022

View reviewed changes

Shadowghost force-pushed the external-sub-audio branch 2 times, most recently from fc2ca88 to 1a61f7b Compare February 12, 2022 19:03

crobibero reviewed Feb 12, 2022

View reviewed changes

Shadowghost force-pushed the external-sub-audio branch from 1a61f7b to 5223a0f Compare February 12, 2022 19:39

1337joe reviewed Feb 12, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/FFProbeProvider.cs Outdated Show resolved Hide resolved

1337joe reviewed Feb 12, 2022

View reviewed changes

Emby.Naming/ExternalFiles/ExternalPathParserResult.cs Outdated Show resolved Hide resolved

1337joe mentioned this pull request Feb 12, 2022

Improve subtitle filename parsing #7060

Closed

1337joe reviewed Feb 12, 2022

View reviewed changes

Emby.Naming/ExternalFiles/ExternalPathParser.cs Outdated Show resolved Hide resolved

1337joe reviewed Feb 12, 2022

View reviewed changes

Emby.Naming/ExternalFiles/ExternalPathParser.cs Outdated Show resolved Hide resolved

1337joe reviewed Feb 12, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs Outdated Show resolved Hide resolved

Shadowghost force-pushed the external-sub-audio branch 7 times, most recently from 4372660 to 701b9e6 Compare February 13, 2022 13:46

cvium reviewed Feb 17, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs Outdated Show resolved Hide resolved

cvium reviewed Feb 17, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs Outdated Show resolved Hide resolved

cvium reviewed Feb 17, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs Outdated Show resolved Hide resolved

cvium reviewed Feb 17, 2022

View reviewed changes

Emby.Naming/ExternalFiles/ExternalPathParser.cs Outdated Show resolved Hide resolved

cvium reviewed Feb 17, 2022

View reviewed changes

Emby.Naming/ExternalFiles/ExternalPathParser.cs Outdated Show resolved Hide resolved

Shadowghost force-pushed the external-sub-audio branch from 0befa53 to 4cbacee Compare February 17, 2022 11:32

Shadowghost requested a review from Bond-009 February 17, 2022 17:12

Shadowghost force-pushed the external-sub-audio branch 2 times, most recently from 881d4f3 to f08ee32 Compare February 17, 2022 19:14

jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Feb 18, 2022

Shadowghost and others added 4 commits February 18, 2022 22:19

feat(external-media): refactor external subtitle and audio provider

ca5112f

feat(external-media): add tests for external audio and subtitle provider

f1878c4

feat(external-media): refactor to generic provider, extend tests and …

719b707

…file recognition, consolidate and extend NamingOptions

fix(external-media): implement review suggestions

a36e34f

Shadowghost force-pushed the external-sub-audio branch from f08ee32 to a36e34f Compare February 18, 2022 21:20

jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Feb 18, 2022

Bond-009 reviewed Feb 19, 2022

View reviewed changes

MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs Outdated Show resolved Hide resolved

Update MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs

bbb3117

Co-authored-by: Bond-009 <bond.009@outlook.com>

joshuaboniface requested a review from Bond-009 February 21, 2022 17:31

Bond-009 approved these changes Feb 21, 2022

View reviewed changes

joshuaboniface merged commit 59040bf into jellyfin:master Feb 21, 2022

1337joe mentioned this pull request Feb 21, 2022

Merge MediaInfoResolver subclass tests #7349

Merged

Shadowghost deleted the external-sub-audio branch February 23, 2022 16:40

crobibero mentioned this pull request Feb 28, 2022

Only add internal files if the internal metadata path exists #7370

Merged

nyanmisaka mentioned this pull request Mar 3, 2022

[Issue]: Subtitles are not being scanned #7361

Closed

1 task

Cosmonear mentioned this pull request Jun 18, 2022

External Subtitle not working since recently jellyfin/jellycon#175

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor and extend external subtitle and audio handling #7255

Refactor and extend external subtitle and audio handling #7255

Shadowghost commented Jan 27, 2022 •

edited

github-actions bot commented Jan 27, 2022 •

edited

What's Changed

`POST` /Dlna/Profiles

Request:

`GET` /Dlna/Profiles/{profileId}

Return Type:

`POST` /Dlna/Profiles/{profileId}

Request:

`GET` /Dlna/Profiles/Default

Return Type:

`POST` /Items/{itemId}/PlaybackInfo

Request:

`POST` /LiveStreams/Open

Request:

`POST` /Sessions/Capabilities/Full

Request:

`GET` /Devices/Info

Return Type:

`GET` /Sessions

Return Type:

`GET` /Devices

Return Type:

`POST` /Users/{userId}/Authenticate

Return Type:

`POST` /Users/AuthenticateByName

Return Type:

`POST` /Users/AuthenticateWithQuickConnect

Return Type:

1337joe commented Feb 17, 2022

Bond-009 left a comment

Dnkhatri commented Feb 27, 2022 •

edited

Shadowghost commented Feb 27, 2022

Dnkhatri commented Feb 27, 2022

Refactor and extend external subtitle and audio handling #7255

Refactor and extend external subtitle and audio handling #7255

Conversation

Shadowghost commented Jan 27, 2022 • edited

github-actions bot commented Jan 27, 2022 • edited

What's Changed

POST /Dlna/Profiles

Request:

GET /Dlna/Profiles/{profileId}

Return Type:

POST /Dlna/Profiles/{profileId}

Request:

GET /Dlna/Profiles/Default

Return Type:

POST /Items/{itemId}/PlaybackInfo

Request:

POST /LiveStreams/Open

Request:

POST /Sessions/Capabilities/Full

Request:

GET /Devices/Info

Return Type:

GET /Sessions

Return Type:

GET /Devices

Return Type:

POST /Users/{userId}/Authenticate

Return Type:

POST /Users/AuthenticateByName

Return Type:

POST /Users/AuthenticateWithQuickConnect

Return Type:

1337joe commented Feb 17, 2022

Bond-009 left a comment

Choose a reason for hiding this comment

Dnkhatri commented Feb 27, 2022 • edited

Shadowghost commented Feb 27, 2022

Dnkhatri commented Feb 27, 2022

Shadowghost commented Jan 27, 2022 •

edited

github-actions bot commented Jan 27, 2022 •

edited

`POST` /Dlna/Profiles

`GET` /Dlna/Profiles/{profileId}

`POST` /Dlna/Profiles/{profileId}

`GET` /Dlna/Profiles/Default

`POST` /Items/{itemId}/PlaybackInfo

`POST` /LiveStreams/Open

`POST` /Sessions/Capabilities/Full

`GET` /Devices/Info

`GET` /Sessions

`GET` /Devices

`POST` /Users/{userId}/Authenticate

`POST` /Users/AuthenticateByName

`POST` /Users/AuthenticateWithQuickConnect

Dnkhatri commented Feb 27, 2022 •

edited