Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HLS transcoding on android tv -- dont use -noaccurate_seek for hls transcode #7338

Merged
merged 1 commit into from Mar 1, 2022

Conversation

mueslimak3r
Copy link
Member

Changes

  • dont use -noaccurate_seek for hls

Issues

  • exoplayer in the Android TV client would get chunks with video that starts earlier than their timestamps. Typically it would be around 4 seconds behind.

    when testing with Add first draft of keyframe extraction for Matroska #6600 on Android-TV I found segments were still inaccurate (off by the time difference between two keyframes), even though the requested time was keyframe-aligned. I assume this is because even though the requested timestamp is keyframe aligned, ffmpeg still only goes up until the preceding keyframe.

    This issue also occurred in the android (mobile) client using the web player backend

    The main resulting issue is that subtitles handled externally can't be synced to the video

Notes

  • with both hls and progressive encodes excluded, and dash not supported, I'm not sure if this block will ever run

@mueslimak3r mueslimak3r changed the title dont use -noaccurate_seek for hls transcode fix HLS transcoding on android tv -- dont use -noaccurate_seek for hls transcode Feb 21, 2022
@joshuaboniface joshuaboniface requested a review from a team February 25, 2022 01:51
@crobibero crobibero merged commit 3c0c757 into jellyfin:master Mar 1, 2022
@mueslimak3r mueslimak3r deleted the hls-remove-seek-param branch March 1, 2022 03:16
@crobibero crobibero added this to Active PRs in Release 10.8.0 via automation Mar 1, 2022
@Bond-009 Bond-009 moved this from Active PRs to Completed PRs in Release 10.8.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants