Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections: Store reliable total duration #7660

Open
doc-code-hub opened this issue Apr 25, 2022 · 3 comments · May be fixed by #7661
Open

Collections: Store reliable total duration #7660

doc-code-hub opened this issue Apr 25, 2022 · 3 comments · May be fixed by #7661
Labels
confirmed This issue has been reviewed and confirmed enhancement Improving an existing function, or small fixes

Comments

@doc-code-hub
Copy link

doc-code-hub commented Apr 25, 2022

Introduction

Viewing the total duration of a content on the detail page can be very useful as information, for organizing or predicting the end.

Likewise, I think it could be convenient and useful to be able to view the total duration of a collection (eg to plan a marathon).

Image from my PR
image

Suggested Enancement

Basically I would like the total RunTimeTicks of the collection to be saved, recursively obtained from all the children.

This way clients would be able to show them immediately in user-readable format.


I had tried to achieve this purpose client-side ( on jellyfin-web #3552 ), however it remains impossible to have a reliable total duration with all types of content ( e.g. with collection inside collection), moreover the information was deduced by the children, who were retrieved at a later time, introducing a delay.

It has been pointed out to me (by @thornbill), and I agree, that it would be much better if this information were computed and stored server-side.

  • It would be much more comfortable
  • It would make the information available immediately
  • It would allow to always have a total effective duration, regardless of the type of content inside (also solving the problem of collection within collection or series).

In this regard, I am trying to propose an implementation on the related PR and i'm open to suggestions (on the PR please :) )

My Implementation in short

  • Add UpdateRunTimeTicksToItems method in BoxSet
  • Handle update of RunTimeTicks when adding/removing items from the collection
  • Add a Task to update the RunTimeTicks for the collections (to handle eventual file remove and RunTimeTicks update)
@doc-code-hub doc-code-hub linked a pull request Apr 25, 2022 that will close this issue
@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale Stale and will be closed if no activity occurs label Aug 24, 2022
@thornbill
Copy link
Member

Still relevant 🙂

@jellyfin-bot jellyfin-bot added this to Needs triage in Issue Triage for Main Repo Aug 24, 2022
@jellyfin-bot jellyfin-bot removed the stale Stale and will be closed if no activity occurs label Aug 25, 2022
@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale Stale and will be closed if no activity occurs label Mar 22, 2023
@thornbill thornbill added enhancement Improving an existing function, or small fixes confirmed This issue has been reviewed and confirmed and removed stale Stale and will be closed if no activity occurs labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue has been reviewed and confirmed enhancement Improving an existing function, or small fixes
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants