Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable "Automatically add to collection" by default #7749

Merged

Conversation

cvium
Copy link
Member

@cvium cvium commented May 15, 2022

Changes
Disabled the feature by default. It's not something most people would want enabled.

Issues
Fixes #7747

@cvium cvium added the stable backport Backport into the next stable release label May 15, 2022
@1337joe
Copy link
Member

1337joe commented May 15, 2022

Just tested this - changing this value doesn't actually default the checkbox to false in library options when creating a new library.

Looks like it's enabled by default in web, which should pick up what the server sends as the library options, but a new library only gets a LibraryOptionsResultDto, not a full VirtualFolderInfo with all the library option values.

Changing it to actually query for a default LibraryOptions to initialize new libraries from is beyond me at the moment, do we want to just change that line in web to match the default on the server side?

@cvium
Copy link
Member Author

cvium commented May 15, 2022

Changing it to actually query for a default LibraryOptions to initialize new libraries from is beyond me at the moment, do we want to just change that line in web to match the default on the server side?

Sure

@joshuaboniface joshuaboniface added this to Active PRs in Release 10.8.0 via automation May 16, 2022
@joshuaboniface joshuaboniface merged commit 8119e4a into jellyfin:release-10.8.z May 16, 2022
Release 10.8.0 automation moved this from Active PRs to Completed PRs May 16, 2022
@jellyfin-bot jellyfin-bot moved this from Completed PRs to Jellyfinished in Release 10.8.0 May 20, 2022
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 20, 2022
crobibero pushed a commit that referenced this pull request May 20, 2022
(cherry picked from commit 8119e4a)
Signed-off-by: crobibero <cody@robibe.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Jellyfinished
Development

Successfully merging this pull request may close these issues.

None yet

6 participants