chore: enable on demand keyframe extraction for mkv #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
approved these changes
Jun 6, 2022
crobibero
approved these changes
Jun 6, 2022
Bond-009
approved these changes
Jun 6, 2022
crobibero
added a commit
that referenced
this pull request
Jun 11, 2022
(cherry picked from commit 2a89683) Signed-off-by: crobibero <cody@robibe.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enables on demand keyframe extraction for the mkv container. It's reasonably fast (completely metadata-based) and we'll get more feedback by enabling it by default