Fix the broken transcoding throttler #7994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
force-pushed
the
fix-throttler
branch
2 times, most recently
from
6d85721
to
6b6a9f6
Compare
cvium
reviewed
Jun 22, 2022
nyanmisaka
force-pushed
the
fix-throttler
branch
2 times, most recently
from
4cbf057
to
d166f77
Compare
|
Debug build is failing (writing it here since we missed it on a PR last time). |
crobibero
approved these changes
Jun 23, 2022
cvium
reviewed
Jun 23, 2022
nyanmisaka
force-pushed
the
fix-throttler
branch
from
c83e3a5
to
52704e8
Compare
cvium
approved these changes
Jun 26, 2022
|
Seems to be fine on browser: It's a +11 -26 change not touching anything unrelated as far as I can see |
nyanmisaka
force-pushed
the
fix-throttler
branch
from
1913fb3
to
506ed69
Compare
|
Rebase fixes the weird issue on GH client. |
jellyfin-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
(cherry picked from commit a7d45b5) Signed-off-by: Joshua Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to modify ffmpeg itself for better implementation in the future.
Or utilize the
realtimefilter to limit the transcoding speed.Changes
Issues
HLS and progressive StreamStates are always disposed prematurely.