Add resolution text for 384 sized video #8212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't mind mereging this but I'd really be interested in an official source for this resolution. |
Shadowghost
approved these changes
Aug 6, 2022
|
The resolution is mentioned in this Wikipedia article, so I guess it does exist in some form. https://en.wikipedia.org/wiki/Computer_display_standard |
nielsvanvelzen
approved these changes
Aug 6, 2022
crobibero
approved these changes
Aug 8, 2022
|
After reviewing more videos, I'd like to also add 400p as a resolution text. Although not a broadcast or home media standard resolution, Scene standard definition releases have a maximum width of 720 and 16:9 aspect ratio results in the following resolutions:
Even though technically 404p would be a more accurate description, 400p is a nice round number and makes me feel warm and fuzzy. But I'd be ok either way. Let me know if it would be fine to update this PR, or if a separate PR would be preferred. |
jellyfin-bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
Add resolution text for 384 sized video Original-merge: 7ffdde9 Merged-by: Cody Robibero <cody@robibe.ro> Backported-by: Joshua Boniface <joshua@boniface.me>
Kakadus
pushed a commit
to Kakadus/jellyfin
that referenced
this pull request
Oct 2, 2022
Add resolution text for 384 sized video Original-merge: 7ffdde9 Merged-by: Cody Robibero <cody@robibe.ro> Backported-by: Joshua Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add 384p as a resolution text output option. This handles the somewhat common low resolution of 512x384. Meant for 10.8 branch.
Updates test.
Issues
Fixes #8099 - handles more another case anyway.
Builds on the work of #8104