Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Changing audio stream does not work in many cases #8673

Closed
1 task done
gdnmhr opened this issue Nov 1, 2022 · 0 comments · Fixed by #8666
Closed
1 task done

[Issue]: Changing audio stream does not work in many cases #8673

gdnmhr opened this issue Nov 1, 2022 · 0 comments · Fixed by #8666
Labels
bug Something isn't working

Comments

@gdnmhr
Copy link

gdnmhr commented Nov 1, 2022

Please describe your bug

Currently, when a media file has two (or more) audio streams, switching between those does not work in most cases. This is due to the API reporting that DirectPlay can be used even though remuxing is required.

In the discussion in jellyfin/jellyfin-web#4045, it turned out that most Browsers will just pick the first audio stream. However, the server assumes the player will play the stream marked as default.
This only works if the default audio stream is also the first one. Interestingly, there can also be multiple default audio streams (this is also the case if none of the streams is marked as default as in this case all will be treated as default).
In this line, the last parameter (isSecondaryAudio) is instantiated with !audioStream.IsDefault. I guess the server should use the index of the audio stream instead.
I am not aware of any browser that actually plays the default stream if multiple streams are provided, however, if there is one, this should be somehow included in the DeviceProfile to be able to distinguish these two cases.

Jellyfin Version

Other

if other:

10.8.6

Environment

- OS: Debain
- Virtualization: Docker
- Clients: Web
- Browser: Chromium & Firefox
- FFmpeg Version: -
- Playback Method: DirectPlay (but should be Remux)
- Hardware Acceleration: -
- Plugins: -
- Reverse Proxy: -
- Base URL: none
- Networking: -
- Storage: local

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant