Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd scrolling behaviour on Home Screen #81

Closed
LeviSnoot opened this issue Jun 21, 2021 · 22 comments
Closed

Odd scrolling behaviour on Home Screen #81

LeviSnoot opened this issue Jun 21, 2021 · 22 comments

Comments

@LeviSnoot
Copy link

Build 50
https://user-images.githubusercontent.com/13402525/122806278-6e425600-d2ca-11eb-8e5a-97f30310923d.MOV

@acvigue acvigue added bug Something isn't working can't reproduce labels Jun 21, 2021
@PangMo5
Copy link
Member

PangMo5 commented Jun 21, 2021

I'll check it

@classicjazz
Copy link

classicjazz commented Jun 21, 2021

I can confirm that this is an issue on my iPhone 12 Max using iOS 14.6.

To reproduce,

  1. on the home screen, scroll all the way down
  2. scroll all the way up until it hits the top and bounces

Updated: This is also a problem on my M1 iPad Pro using iOS 14.6, just much less of an issue. Again, it seems to be caused by scrolling back to the top until it bounces.

@acvigue
Copy link
Member

acvigue commented Jun 22, 2021

iOS v?
15 has known issues with the home screen.

@PangMo5
Copy link
Member

PangMo5 commented Jun 22, 2021

This may be a problem with the combination of Spacer and iOS 15(Maybe not), LazyVStack, and NavigationView.

Currently, I think we're using Spacer to set the spacing between views.
Maybe this is the same as using Color.clear
This is not Apple's intended method and may have unintended side effects.
Therefore, it would be better to use .padding for spacing between views.

If replace that part with padding, it works normally.

@PangMo5
Copy link
Member

PangMo5 commented Jun 22, 2021

Of course, this may be resolved in beta later 😋

@acvigue
Copy link
Member

acvigue commented Jun 22, 2021

If replace that part with padding, it works normally.

would you be willing to throw up a quick PR with the changes?

@PangMo5
Copy link
Member

PangMo5 commented Jun 22, 2021

If replace that part with padding, it works normally.

would you be willing to throw up a quick PR with the changes?

Yes, the corresponding part has been modified,
but I can see other problems on the home screen,
so I will upload them after I correct them.

acvigue added a commit to PangMo5/Swiftfin that referenced this issue Jun 22, 2021
acvigue added a commit that referenced this issue Jun 22, 2021
@acvigue acvigue reopened this Jun 22, 2021
@acvigue
Copy link
Member

acvigue commented Jun 22, 2021

reopening until proven fixed.

@LeviSnoot
Copy link
Author

iOS v?
15 has known issues with the home screen.

v14.6

@classicjazz
Copy link

I updated my comments to reflect 14.6 on both devices.

@Hukuma1
Copy link

Hukuma1 commented Jun 22, 2021

iOS v14.3 same thing. Also has weird binding/bounce if you flip orientation into landscape mode.

@krutburken
Copy link

Can also confirm this on 14.6 (12 mini)

@acvigue
Copy link
Member

acvigue commented Jun 23, 2021

may be fixed in 51

@acvigue
Copy link
Member

acvigue commented Jun 25, 2021

please lmk if this still occurs in 53.

@classicjazz
Copy link

Definitely improved on the iPhone 12 Max running 14.6. I don't see it screen redraw (fluttering) at all in either landscape or portrait mode.

Almost fixed on the M1 iPad Pro running 14.6. No artifacts in landscape mode. But there are still screen redraw (fluttering) issues in portrait mode there.

@PangMo5
Copy link
Member

PangMo5 commented Jun 25, 2021

Definitely improved on the iPhone 12 Max running 14.6. I don't see it screen redraw (fluttering) at all in either landscape or portrait mode.

Almost fixed on the M1 iPad Pro running 14.6. No artifacts in landscape mode. But there are still screen redraw (fluttering) issues in portrait mode there.

Can you upload the example video that working on the M1 iPad Pro?

@LeviSnoot
Copy link
Author

please lmk if this still occurs in 53.

Fixed for me in build 53

@Hukuma1
Copy link

Hukuma1 commented Jun 25, 2021

Ditto. Fixed on my iPhone 11 Pro. Thanks!

@acvigue
Copy link
Member

acvigue commented Jun 25, 2021

np. closing.

@acvigue acvigue closed this as completed Jun 25, 2021
@acvigue acvigue removed bug Something isn't working can't reproduce labels Jun 25, 2021
@classicjazz
Copy link

classicjazz commented Jun 25, 2021

Definitely improved on the iPhone 12 Max running 14.6. I don't see it screen redraw (fluttering) at all in either landscape or portrait mode.
Almost fixed on the M1 iPad Pro running 14.6. No artifacts in landscape mode. But there are still screen redraw (fluttering) issues in portrait mode there.

Can you upload the example video that working on the M1 iPad Pro?

Here is a link to a video of the flicker when in portrait mode, but not landscape: [remove]

To replicate, scroll up until it bounces. Then the flicker / screen redraw issue occurs on the M1 iPad running 14.6.

@PangMo5
Copy link
Member

PangMo5 commented Jun 25, 2021

Here is a link to a video of the flicker when in portrait mode, but not landscape: https://drive.google.com/file/d/1DStUV2lE1eocFzddnZ7GzuuRuo0jmM2N/view

To replicate, scroll up until it bounces. Then the flicker / screen redraw issue occurs on the M1 iPad running 14.6.

cant access to link

@classicjazz
Copy link

I regenerated the shared link: https://drive.google.com/file/d/1DStUV2lE1eocFzddnZ7GzuuRuo0jmM2N/view?usp=sharing

Hopefully this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants