Modify default INTEGRATED_TURN_LISTEN_IP #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 90.21% 89.41% -0.80%
==========================================
Files 32 32
Lines 378 378
==========================================
- Hits 341 338 -3
- Misses 37 40 +3 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
May 24, 2023
| @@ -13,7 +13,7 @@ It leverages the [Membrane RTC Engine](https://github.com/jellyfish-dev/membrane | |||
|
|
|||
| There are two ways of running Jellyfish: | |||
| - building from source (requires Elixir and native dependencies) | |||
| - using Jellyfish Docker images | |||
| - using Jellyfish Docker images (Remember that you should set `INTEGRATED_TURN_IP` env to your public IP address and `INTEGRATED_TURN_LISTEN_IP` to `0.0.0.0`). | |||
There was a problem hiding this comment.
Could we move this to jellyfish docs? https://jellyfish-dev.github.io/jellyfish-docs/getting_started/peers/webrtc
There was a problem hiding this comment.
I think it could stay here, but I also added it to the jellyfish docs.
fishjam-dev/fishjam-docs#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.