Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtc 275 tcp turn fallback #46

Merged
merged 5 commits into from Jun 28, 2023
Merged

Rtc 275 tcp turn fallback #46

merged 5 commits into from Jun 28, 2023

Conversation

roznawsk
Copy link
Member

@roznawsk roznawsk commented Jun 27, 2023

  • Added TCP turn as fallback, removed tls (we have never used it anyway).
  • Fixed simulcast.

@roznawsk roznawsk requested a review from mickel8 June 27, 2023 13:53
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #46 (73cafcc) into main (0538894) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   90.18%   90.13%   -0.06%     
==========================================
  Files          32       32              
  Lines         377      375       -2     
==========================================
- Hits          340      338       -2     
  Misses         37       37              
Impacted Files Coverage Δ
lib/jellyfish/room.ex 81.63% <75.00%> (-0.19%) ⬇️
lib/jellyfish/peer/webrtc.ex 80.00% <100.00%> (-1.82%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0538894...73cafcc. Read the comment docs.

config/runtime.exs Outdated Show resolved Hide resolved
lib/jellyfish/room.ex Outdated Show resolved Hide resolved
lib/jellyfish/room.ex Outdated Show resolved Hide resolved
lib/jellyfish/room.ex Outdated Show resolved Hide resolved
@roznawsk roznawsk requested a review from mickel8 June 28, 2023 09:49
@roznawsk roznawsk merged commit 9046a4d into main Jun 28, 2023
5 checks passed
@roznawsk roznawsk deleted the RTC-275-tcp-turn-fallback branch June 28, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants