Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve outdated HEALTHCHECK in Dockerfile #64

Merged
merged 4 commits into from Aug 10, 2023
Merged

Improve outdated HEALTHCHECK in Dockerfile #64

merged 4 commits into from Aug 10, 2023

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 7, 2023 •
edited

Dockerfile contains outdated HEALTHCHECK (that calls non-existent endpoint) and EXPOSE instructions. This PR replaces them.

@LVala LVala requested a review from mickel8 August 7, 2023 13:59
@LVala LVala self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited

Codecov Report

Merging #64 (7057e37) into main (1ed3220) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          34       34           
  Lines         536      536           
=======================================
  Hits          449      449           
  Misses         87       87

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed3220...7057e37. Read the comment docs.

@LVala LVala removed the request for review from mickel8 August 7, 2023 14:08
@LVala LVala changed the title Remove outdated HEALTHCHECK from Dockerfile Improve outdated HEALTHCHECK in Dockerfile Aug 7, 2023
@LVala
Copy link
Member Author

LVala commented Aug 7, 2023 •
edited

TODO: remove existing healthcheck in docker-compose.yml DONE

@LVala LVala requested a review from mickel8 August 8, 2023 07:04
@sgfn sgfn self-requested a review August 8, 2023 12:58
sgfn
sgfn requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary lock on merging into main

@LVala LVala requested a review from sgfn August 9, 2023 07:46
sgfn
sgfn reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead

@sgfn sgfn self-requested a review August 9, 2023 14:42
@LVala LVala merged commit 0d02f88 into main Aug 10, 2023
6 checks passed
@LVala LVala deleted the fix-dockerfile branch August 10, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickel8 mickel8 mickel8 approved these changes

@sgfn sgfn sgfn approved these changes

Assignees

@LVala LVala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LVala @mickel8 @sgfn