This repository has been archived by the owner on May 10, 2024. It is now read-only.
[RTC-117] Move typed emitter to runtime deps #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure? Language Server was suggesting events names in Neovim just fine when I was modifying integration tests in |
LVala
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
I've checked it and you're right, although for some reason when building locally, it worked fine, maybe wait for @kamil-stasiak comment as I'm no expert on typescript.
mickel8
changed the title
|
@ostatni5 said it looks ok so I am merging |
|
According to stackoverflow, if types are exposed to the library user, they should be in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't TypedEmitter be in runtime deps? I can see that it's in dev deps in ts-client-sdk but when it's in dev deps, VSCode cannot see
onproperty on WebRTCEndpoint class 🤔