Add get_forwarded_tracks function #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 51.63% 52.23% +0.59%
==========================================
Files 36 39 +3
Lines 1925 1968 +43
==========================================
+ Hits 994 1028 +34
- Misses 931 940 +9
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
roznawsk
approved these changes
Jul 24, 2023
lib/membrane_rtc_engine/engine.ex
Outdated
| @doc """ | ||
| Returns number of forwarded tracks in RTC Engine. | ||
| """ | ||
| @spec get_forwarded_tracks(rtc_engine :: pid()) :: integer() |
There was a problem hiding this comment.
[nitpick]
Suggested change
| @spec get_forwarded_tracks(rtc_engine :: pid()) :: integer() | |
| @spec get_forwarded_tracks_number(rtc_engine :: pid()) :: integer() |
alternatively:
get_forwarded_track_count
get_num_forwarded_tracks
Rados13
force-pushed
the
feature/add-forwarded-tracks-metric
branch
from
21711f2
to
78000b5
Compare
sgfn
reviewed
Jul 25, 2023
mickel8
requested changes
Jul 26, 2023
Rados13
force-pushed
the
feature/add-forwarded-tracks-metric
branch
from
45eeda3
to
9a070da
Compare
Karolk99
approved these changes
Aug 1, 2023
Rados13
force-pushed
the
feature/add-forwarded-tracks-metric
branch
from
4cfb8b6
to
dbc270f
Compare
mickel8
requested changes
Aug 3, 2023
membrane_rtc_engine/lib/membrane_rtc_engine/static_track_sender.ex
Outdated
Show resolved
Hide resolved
mickel8
approved these changes
Aug 4, 2023
Rados13
force-pushed
the
feature/add-forwarded-tracks-metric
branch
from
ed5ed6a
to
631d905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.