Add sc_threshold=0 to H264 encoder in HLS. Release engine 0.17.0, endpoints 0.2.0
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Aug 25, 2023
sgfn
changed the title
sc_threshold=0 to H264 encoder in HLS. Release engine 0.17.0, endpoints 0.2.0
Karolk99
approved these changes
Aug 25, 2023
| @@ -426,7 +426,8 @@ defmodule Membrane.RTC.Engine.Endpoint.HLS do | |||
| |> child(:encoder, %Membrane.H264.FFmpeg.Encoder{ | |||
| profile: :baseline, | |||
| tune: :zerolatency, | |||
| gop_size: frames_per_second * seconds_number | |||
| gop_size: frames_per_second * seconds_number, | |||
| sc_threshold: 0 | |||
There was a problem hiding this comment.
I would add some comment here, about the purpose of this change
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 52.66% 52.81% +0.15%
==========================================
Files 38 38
Lines 1973 1973
==========================================
+ Hits 1039 1042 +3
+ Misses 934 931 -3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.