[RTC-398] File endpoint autoplay #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 54.37% 54.35% -0.02%
==========================================
Files 41 41
Lines 2082 2088 +6
==========================================
+ Hits 1132 1135 +3
- Misses 950 953 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Karolk99
requested changes
Dec 5, 2023
roznawsk
force-pushed
the
RTC-398-file-autoplay
branch
from
13f1f0b
to
937e855
Compare
mickel8
approved these changes
Dec 5, 2023
Rados13
approved these changes
Dec 6, 2023
file/test/file_endpoint_test.exs
Outdated
| assert File.read!(output_file) |> byte_size() == File.read!(reference_path) |> byte_size() | ||
| assert File.read!(output_file) == File.read!(reference_path) | ||
|
|
||
| Process.sleep(200) |
There was a problem hiding this comment.
Why do we need this Process.sleep? It's look a little bit random.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.