Recording endpoint #356
Merged
Recording endpoint #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
force-pushed
the
recording-endpoint
branch
from
168c3c7
to
0b2ab51
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 53.39% 52.76% -0.64%
==========================================
Files 53 58 +5
Lines 2459 2534 +75
==========================================
+ Hits 1313 1337 +24
- Misses 1146 1197 +51
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
roznawsk
approved these changes
Feb 14, 2024
Rados13
reviewed
Feb 14, 2024
mickel8
approved these changes
Feb 15, 2024
| @track_reports_keys [:type, :encoding, :offset, :clock_rate, :metadata] | ||
|
|
||
| @type filename :: String.t() | ||
| @type track_report :: %{ |
There was a problem hiding this comment.
It might be useful to also have the duration of a track but we can add it later
Rados13
approved these changes
Feb 23, 2024
Rados13
force-pushed
the
recording-endpoint
branch
from
4b6d0f6
to
bfc3568
Compare
Co-authored-by: Przemysław Rożnawski <48837433+roznawsk@users.noreply.github.com>
Co-authored-by: Przemysław Rożnawski <48837433+roznawsk@users.noreply.github.com>
Co-authored-by: Przemysław Rożnawski <48837433+roznawsk@users.noreply.github.com>
Co-authored-by: Przemysław Rożnawski <48837433+roznawsk@users.noreply.github.com>
Co-authored-by: Przemysław Rożnawski <48837433+roznawsk@users.noreply.github.com>
Co-authored-by: Michał Śledź <michalsledz34@gmail.com>
Rados13
force-pushed
the
recording-endpoint
branch
2 times, most recently
from
3755894
to
e7c0319
Compare
Rados13
force-pushed
the
recording-endpoint
branch
from
e7c0319
to
ada9ef6
Compare
Karolk99
force-pushed
the
recording-endpoint
branch
from
71fa00d
to
149c762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.