Refactor storage API #375
Refactor storage API #375
Conversation
Karolk99
force-pushed
the
recording-endpoint-refactor
branch
from
40ed8c2
to
bf34948
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 53.31% 53.18% -0.13%
==========================================
Files 61 59 -2
Lines 2592 2587 -5
==========================================
- Hits 1382 1376 -6
- Misses 1210 1211 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
recording/lib/storage/s3.ex
Outdated
There was a problem hiding this comment.
I think we should provide a way to specify a common prefix for created recording files. Because currently, recording files will be created in a specified bucket under key <recording_id>/<filename> and IMO it should be possible to specify that recording files will be stored under key recording/<recording_id>/<filename>. It would be also more symmetric with Storage.File.
| @@ -162,7 +162,9 @@ defmodule Membrane.RTC.RecordingEndpointTest do | |||
| setup_mock_http_request() | |||
|
|
|||
| recording_endpoint = | |||
| create_recording_endpoint(rtc_engine, [{Storage.S3, %{credentials: @credentials}}]) | |||
| create_recording_endpoint(rtc_engine, [ | |||
| {Storage.S3, %{credentials: @credentials, path_prefix: ""}} | |||
There was a problem hiding this comment.
I think that if path_prefix is not provided a default value should be used which would be "" .
No description provided.