Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC-505 Save report only when it contains any track #379

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

Rados13
Copy link
Contributor

@Rados13 Rados13 commented Mar 26, 2024

No description provided.

@Rados13 Rados13 self-assigned this Mar 26, 2024
@Rados13 Rados13 force-pushed the save_only_report_with_tracks branch from 066f06e to 311b2d6 Compare March 26, 2024 07:56
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #379 (10d7071) into master (d8e9f6f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   53.30%   53.28%   -0.03%     
==========================================
  Files          62       62              
  Lines        2634     2635       +1     
==========================================
  Hits         1404     1404              
- Misses       1230     1231       +1     
Files Coverage Δ
recording/lib/recording_endpoint.ex 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e9f6f...10d7071. Read the comment docs.

@Rados13 Rados13 marked this pull request as ready for review March 26, 2024 08:34
@Rados13 Rados13 requested a review from Karolk99 March 26, 2024 08:34
@Rados13 Rados13 changed the title Save report only when it contains any track RTC-505 Save report only when it contains any track Mar 26, 2024
recording/lib/recording_endpoint.ex Outdated Show resolved Hide resolved
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
@Rados13 Rados13 merged commit 2a0952a into master Mar 27, 2024
24 checks passed
@Rados13 Rados13 deleted the save_only_report_with_tracks branch March 27, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants