Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge membrane_webrtc_plugin #384

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Merge membrane_webrtc_plugin #384

merged 4 commits into from
Apr 12, 2024

Conversation

mickel8
Copy link
Contributor

@mickel8 mickel8 commented Apr 9, 2024

membrane_webrtc_plugin is not intended to be used outside membrane_rtc_engine as it is too tightly coupled to the webrtc endpoint.

Because of that, and because Membrane Team created a new membrane_webrtc_plugin that uses Elixir WebRTC under the hood and has a brand new API, we want to merge the old membrane_webrtc_plugin and release its name for the new Membrane's package.

New Membrane's plugin: https://github.com/membraneframework-labs/membrane_webrtc_plugin
Old Jellyfish plugin: https://github.com/jellyfish-dev/membrane_webrtc_plugin

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #384 (1677afb) into master (5500016) will decrease coverage by 0.31%.
The diff coverage is 52.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   54.66%   54.36%   -0.31%     
==========================================
  Files          64       75      +11     
  Lines        2720     3254     +534     
==========================================
+ Hits         1487     1769     +282     
- Misses       1233     1485     +252     
Files Coverage Δ
webrtc/lib/webrtc_endpoint.ex 0.00% <ø> (ø)
webrtc/lib/endpoint_bin/extension/mid.ex 83.33% <83.33%> (ø)
webrtc/lib/endpoint_bin/extension/rid.ex 83.33% <83.33%> (ø)
webrtc/lib/endpoint_bin/metrics.ex 0.00% <0.00%> (ø)
webrtc/lib/endpoint_bin/extension.ex 60.00% <60.00%> (ø)
webrtc/lib/endpoint_bin/extension/repaired_rid.ex 16.66% <16.66%> (ø)
webrtc/lib/endpoint_bin/extension/vad.ex 0.00% <0.00%> (ø)
webrtc/lib/endpoint_bin/extension/twcc.ex 0.00% <0.00%> (ø)
webrtc/lib/endpoint_bin/utils.ex 0.00% <0.00%> (ø)
webrtc/lib/endpoint_bin/track.ex 77.10% <77.10%> (ø)
... and 3 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5500016...1677afb. Read the comment docs.

@mickel8 mickel8 force-pushed the webrtc-plugin branch 4 times, most recently from a2ebcf6 to 53b62b7 Compare April 10, 2024 10:17
@mickel8 mickel8 requested a review from Rados13 April 10, 2024 10:43
Copy link
Contributor

@Rados13 Rados13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is outdated compared to the master. You could rebase with master before merging this PR, but that is only a suggestion.

@mickel8 mickel8 merged commit 78bfa05 into master Apr 12, 2024
30 checks passed
@mickel8 mickel8 deleted the webrtc-plugin branch April 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants