Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application and TaskSupervisor in RecordingEndpoint #386

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Rados13
Copy link
Contributor

@Rados13 Rados13 commented Apr 10, 2024

No description provided.

@Rados13 Rados13 requested a review from Karolk99 April 10, 2024 10:25
@Rados13 Rados13 self-assigned this Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #386 (eb84f8c) into master (c699dbd) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   54.68%   54.66%   -0.03%     
==========================================
  Files          64       64              
  Lines        2719     2720       +1     
==========================================
  Hits         1487     1487              
- Misses       1232     1233       +1     
Files Coverage Δ
recording/lib/recording_endpoint.ex 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c699dbd...eb84f8c. Read the comment docs.

@Rados13 Rados13 marked this pull request as ready for review April 10, 2024 10:36
Copy link
Contributor

@Karolk99 Karolk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Rados13 Rados13 force-pushed the fix/resource-guard-recording-endpoint branch from 7ca8baa to eb84f8c Compare April 11, 2024 10:11
@Rados13 Rados13 merged commit 5500016 into master Apr 11, 2024
23 checks passed
@Rados13 Rados13 deleted the fix/resource-guard-recording-endpoint branch April 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants