Recording/change s3 on close mechanism #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
force-pushed
the
recording/change-s3-on-close-mechanism
branch
from
3cecc3c
to
f587874
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 54.04% 54.17% +0.12%
==========================================
Files 74 75 +1
Lines 3249 3258 +9
==========================================
+ Hits 1756 1765 +9
Misses 1493 1493
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2 tasks
Rados13
approved these changes
Apr 16, 2024
recording/lib/storage/s3.ex
Outdated
Comment on lines
163
to
186
| defp stream_object(file_path, config, storage_opts) do | ||
| path_prefix = Map.get(storage_opts, :path_prefix, "") | ||
| path = Path.join([path_prefix, config.filename]) | ||
| credentials = storage_opts.credentials | ||
| aws_config = create_aws_config(credentials) | ||
|
|
||
| result = | ||
| file_path | ||
| |> ExAws.S3.Upload.stream_file() | ||
| |> ExAws.S3.upload(credentials.bucket, path) | ||
| |> ExAws.request(aws_config) | ||
|
|
||
| case result do | ||
| {:ok, %{status_code: 200}} -> | ||
| :ok | ||
|
|
||
| {:error, response} -> | ||
| Membrane.Logger.error( | ||
| "Couldn't stream object on S3 bucket, recording id: #{config.recording_id}" | ||
| ) | ||
|
|
||
| {:error, response} | ||
| end | ||
| end |
There was a problem hiding this comment.
This looks pretty similar to save_object, only the inner path is different. Could we avoid duplication of the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.