Fix issues with shaded dependencies #62
Conversation
- Rely on fabric language kotlin to provide kotlinx.serialization - Relocate all shaded dependencies into subpackage Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
|
By the look of things, this PR would also fix my issue #65 . |
|
Hi, @fengshuo2004, this PR is only for the fabric 1.20 branch, as that was the version I was using. However, applying the same to the other branches should be quite easy, and I can do so if you'd like, as welll as providing instructions for how to compile it yourself so you can fix the issue. However, mohist is not exactly the best and has many issues, so I also recommend giving this and this a read. Mohist can often be the cause for issues encountered, however I don't believe it is the issue here. But, often mohist is the cause of the issue. |
@solonovamax Thanks for the reply. I am not using Mohist, I'm using Magma. I'll clone your repo and make the same changes to the Forge branch. I have some Java dev experience so should figure this stuff out no problem. I'll let you know if it fixes my issue. |
|
the same thing that was said about mohist applies to magma. |
|
Just coming back to say that after making my own build, this does indeed fix #65 . My opinion is, a patch is always nice to have as long as the patch doesn't break something else. But if Jen isn't willing to accept it, I'll just report the issue to Magma instead, no big deal. In any case, thanks for the PR @solonovamax ! |
in this particular instance, it is not an issue with magma however, magma can cause many other issues, so it's basically the first thing you should check for issues. |
Check jenchanws#62 for more info.
Fixes #61.
Similar to #59.