Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Search for multiple words #564

Open
TheBossHoggs opened this issue Mar 10, 2021 · 5 comments
Open

Ability to Search for multiple words #564

TheBossHoggs opened this issue Mar 10, 2021 · 5 comments
Labels

Comments

@TheBossHoggs
Copy link

Hi, been really loving and enjoying rednotebook, but i noticed the feature to search for multiple words is absent. not sure if this is already in and i am not seeing it or it is planned for future release.

The ability to search in RedNotebook is one of its greatest features and i think with improving it and adding this ability it will make the program that much stronger

Thanks

@RJ722
Copy link
Contributor

RJ722 commented Mar 11, 2021

We are indeed working on adding support for searching multiple words in #558. In fact, the implementation is almost finalize, so expect a release very soon. \o/

@TheBossHoggs: if you are comfortable with building rednotebook from scratch, it would be great if you can test the code on that PR, and let us know what you think. It will be helpful for us! :)

@TheBossHoggs
Copy link
Author

Will work on that and let you know! thanks for the quick response. ill post my findings to this thread!

@TheBossHoggs
Copy link
Author

I followed the add and deletions to files present from "files changed" in #558 and i couldnt get it to work fully, i am going to continue to debug today, but currently having a few issues i believe due to both syntax issues and me being a newbie with python, i am on rednotebook 2.21 and will keep you updated of my findings

@TheBossHoggs
Copy link
Author

here is an output of the errors i get, any ideas? on how to fix? i can show code if needed
Traceback (most recent call last):
File "/usr/bin/rednotebook", line 6, in
import journal
ModuleNotFoundError: No module named 'journal'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/share/rednotebook/rednotebook/gui/browser.py", line 86, in on_load_changed
if self.search_queries:
AttributeError: 'Cloud' object has no attribute 'search_queries'
Error in sys.excepthook:
Traceback (most recent call last):
File "/usr/bin/rednotebook", line 6, in
import journal
ModuleNotFoundError: No module named 'journal'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 153, in apport_excepthook
with os.fdopen(os.open(pr_filename,
FileNotFoundError: [Errno 2] No such file or directory: '/var/crash/_usr_share_rednotebook_run.py.0.crash'

Original exception was:
Traceback (most recent call last):
File "/usr/bin/rednotebook", line 6, in
import journal
ModuleNotFoundError: No module named 'journal'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/share/rednotebook/rednotebook/gui/browser.py", line 86, in on_load_changed
if self.search_queries:
AttributeError: 'Cloud' object has no attribute 'search_queries'
2021-03-12 07:49:18,848 DEBUG Main frame destroyed
2021-03-12 07:49:18,850 INFO Nothing to save
2021-03-12 07:49:18,850 INFO Goodbye!
2021-03-12 07:49:18,861 INFO Peak memory: 134417924 KiB

@RJ722
Copy link
Contributor

RJ722 commented Mar 13, 2021

File "/usr/share/rednotebook/rednotebook/gui/browser.py", line 86, in on_load_changed
if self.search_queries:
AttributeError: 'Cloud' object has no attribute 'search_queries'

Ha, that looks like an old version in the same PR.

I followed the add and deletions to files present from "files changed" in #558

I suspect that a commit got lost somewhere, or that the changes weren't applied cleanly. Can you maybe try checking out the branch using git:

git clone https://github.com/jendrikseipp/rednotebook/
cd rednotebook/
git fetch origin new-search
git checkout new-search

If you don't want to use git, try applying this patch on latest rednotebook. Something like the following should work I suppose:

cd rednotebook
curl https://patch-diff.githubusercontent.com/raw/jendrikseipp/rednotebook/pull/558.diff | patch -p1 --verbose

Regarding the other import error, I am assuming that there was a problem during installation. Did you follow instructions from https://github.com/jendrikseipp/rednotebook/#install-on-linux? Note that you'd need all the requiremenets as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants