Added Java Module System support #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are this tests still failing? Couldn't reproduce it. |
|
It looks like the PR passed the CI build.... probably the tests fail due to my IDE setup? (used IntelliJ 2020.1) I will use the new build jar into my application with jlink packaging and l'll report back. PS: Good job with keeping the project alive! Thanks for sharing it! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gradle version needs to be at least 6.4 for implementing the support. Docs source
FYI: there are 3 test failing: readGPXv10_1, readGPXv10_2 and readGPXv10_3 (GPXTest.java:537; GPXTest.java:556; GPXTest.java:574). Could you look into it?