Make clearfix alias a method #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the text 'clearfix' to 'group' when it is not called as a method anyhow - which as far as I can see is the only valid way to use clearfix. See issue #263
|
Hey congrats on your first PR ever! 🎉 Just curious, does this actually fix the problem? Did you test this out? |
|
Thank you! Exciting and satisfying though a small contribution. And yes - I did and it did. |
|
Awesome, thanks for jumping in and getting your hands dirty. I'll get this released right now 😁 |
This was referenced Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make clearfix alias a method. This is to avoid rewriting occurrences of the text
clearfixtogroupwhen it is not called as a method anyhow - which as far as I can see is the only valid way to use clearfix. See issue #263Doing this ease usage alongside other libraries that also use
clearfix.This, by the way, is my first pull request ever.