Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix and regex fixes for win32 #563

Merged
merged 2 commits into from
Sep 24, 2014
Merged

posix and regex fixes for win32 #563

merged 2 commits into from
Sep 24, 2014

Conversation

samccone
Copy link
Collaborator

@samccone samccone mentioned this pull request Sep 24, 2014
Closed
@samccone samccone force-pushed the sjs/fix-posix branch 2 times, most recently from f4c9296 to 275c993 Compare September 24, 2014 01:46
@jescalan
Copy link
Owner

hahaha

@jescalan
Copy link
Owner

Still a bunch of failing tests here...

@philbarr
Copy link

Still working on getting the tests to pass. Even more fun, I have different tests failing on Windows than on the Travis report, particularly because of CR line endings.
At some point I'm going to setup a VagrantFile with ubuntu and node so I can run the tests on both systems easily.
This stuff might take a few days though...

@samccone
Copy link
Collaborator Author

@philbarr I am also working on this :)

@jescalan
Copy link
Owner

You guys are the best ✨ 💖 ✨

@samccone
Change posix module to optional dependency
f21850a 
- Add posix to optionalDependencies in package.json
- Change config.coffee to allow posix to be optional
- Change index.coffee to allow posix to be optional

Fixes #556
@samccone samccone force-pushed the sjs/fix-posix branch 2 times, most recently from 0159821 to 69685e8 Compare September 24, 2014 18:53
@samccone
Copy link
Collaborator Author

ok @Jenius this is a solid first step ihmo it gets us a bunch closer

here is a list of the remaining issues when you run npm test

https://gist.github.com/samccone/0bdb7b2d226715f29587

@samccone samccone changed the title Change posix module to optional dependency posix and regex fixes for win32 Sep 24, 2014
@jescalan
Copy link
Owner

Awesome, tests passing on travis now is a great step. This should be set for merge then, although it certainly doesn't mean we're done with windoge, unfortunately.

Thanks so much again for working on this, really appreciate it!

jescalan pushed a commit that referenced this pull request Sep 24, 2014
Merge pull request #563 from jenius/sjs/fix-posix
468d014 
posix and regex fixes for win32
@jescalan jescalan merged commit 468d014 into v3 Sep 24, 2014
@jescalan jescalan deleted the sjs/fix-posix branch September 24, 2014 21:35
@snowe2010
Copy link
Contributor

yay!

@jescalan
Copy link
Owner

Still some work to go, but we're getting there!

@philbarr
Copy link

afraid these fail on windows again. will have a look in the morning.
was my regex fix making the tests fail? because this line doesn't work on win:
res = res.replace(///.[^#{path.sep}]*$///, ".#{ext}")

@samccone
Copy link
Collaborator Author

0a6a076#diff-4686cd02b4515f89676790b7797d14f4R155

Was the fix

@gosteev gosteev mentioned this pull request Oct 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samccone @jescalan @philbarr @snowe2010