Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect port in deploy-for-production.sh, formatting issues in README.md #121

Closed
benjaminlimjt opened this issue Oct 28, 2022 · 1 comment

Comments

@benjaminlimjt
Copy link

In jenkins/scripts/deploy-for-production.sh, Line 32, the script is serving the application at the wrong port. In the tutorial Build a Multibranch Pipeline Project, it is stated that the web application is available at http://localhost:5000. However, the script serves the application at port 3000.

Proposed change:

Before

./node_modules/serve/build/main.js -s build -l 3000 &

After

./node_modules/serve/build/main.js -s build -l 5000 &

In addition, there is a hyperlink formatting issue in README.md, Line 21. (unless it is intentional.)

Not making a pull-request as it seems to not be accepted in this repository.

@MarkEWaite
Copy link
Contributor

Thanks for the report. Fixed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants