Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-2487] Remove deprecated analysis plugins from update center #2089

Closed
jenkins-infra-bot opened this issue Feb 26, 2020 · 16 comments
Closed

Comments

@jenkins-infra-bot
Copy link
Author

danielbeck:

As of today, doing this will necessitate suspending distributions of the following plugins:

  • (analysis-collector depends on analysis-core)
  • android-lint depends on analysis-core
  • brakeman depends on analysis-core
  • ccm depends on analysis-core
  • CFLint depends on analysis-core
  • (checkstyle depends on analysis-core)
  • ci-game depends on analysis-core
  • codeclimate-plugin depends on analysis-core
  • codescanner depends on analysis-core
  • cpptest depends on analysis-core
  • DotCi-Plugins-Starter-Pack depends on pmd, analysis-core, findbugs, analysis-collector, checkstyle
  • (dry depends on analysis-core)
  • (findbugs depends on analysis-core)
  • php depends on pmd, analysis-core, dry, checkstyle
  • (pmd depends on analysis-core)
  • swamp depends on analysis-core
  • (tasks depends on analysis-core)
  • (warnings depends on analysis-core)

 

@jenkins-infra-bot
Copy link
Author

drulli:

This is quite interesting I never realized that there are so many other tools using the plugins.

@jenkins-infra-bot
Copy link
Author

danielbeck:

Ulli Hafner Is this issue still something you'd like to see implemented? If so I recommend starting a dev list conversation given the downstream impact.

@jenkins-infra-bot
Copy link
Author

drulli:

Well, I'll at least ping the authors of those plugins first...

@jenkins-infra-bot
Copy link
Author

drulli:

I went through the list and tried to consolidate the usage of analysis-core.

These plugins can be removed already (already marked as deprecated or archived):

  • (analysis-collector depends on analysis-core)
  • android-lint depends on analysis-core
  • ccm depends on analysis-core
  • (checkstyle depends on analysis-core)
  • (dry depends on analysis-core)
  • (findbugs depends on analysis-core)
  • (tasks depends on analysis-core)
  • (warnings depends on analysis-core)
  • (pmd depends on analysis-core)
  • php depends on pmd, analysis-core, dry, checkstyle

That plugin just "collects" other plugins and can be removed as well:

  • DotCi-Plugins-Starter-Pack depends on pmd, analysis-core, findbugs, analysis-collector, checkstyle

These plugins look outdated and are not maintained anymore:

  • codeclimate-plugin depends on analysis-core
  • codescanner depends on analysis-core
  • cpptest depends on analysis-core

I informed the following plugin authors about the end-of-life notice of analysis-core:

  • brakeman depends on analysis-core
  • CFLint depends on analysis-core
  • swamp depends on analysis-core

So it might make sense to leave analysis-core active until I get an answer of the latter three plugins . But it would be helpful to archive the other ones that depend on analysis core. What do you think?

@jenkins-infra-bot
Copy link
Author

danielbeck:

brakeman depends on analysis-core

Last normal release in mid 2017, since then only a security update. Would contact the maintainer about this.

CFLint depends on analysis-core

39 installs, last release 5 years ago. Would ignore.

swamp depends on analysis-core

Seems active, but just 18 reported installs should allow more flexibility in doing a major upgrade (e.g. integrating with warnings-ng instead).


With jenkinsci/jenkins#4073 additionally, it'll be more painful for users to keep such plugins around.

 

@jenkins-infra-bot
Copy link
Author

drulli:

Yes, I pinged all three authors already. I'm not sure if we should wait for a reply...

@jenkins-infra-bot
Copy link
Author

danielbeck:

Yes, I pinged all three authors already. I'm not sure if we should wait for a reply...

Any news here Ulli Hafner?

@jenkins-infra-bot
Copy link
Author

drulli:

brakeman: see jenkinsci/brakeman-plugin#23 (I'm not sure if we can expect an implementation soon).
No feedback from the other two.

For me it would be ok to remove the plugin now.

@jenkins-infra-bot
Copy link
Author

@jenkins-infra-bot
Copy link
Author

@jenkins-infra-bot
Copy link
Author

drulli:

Brakeman is now released in 8.5.0 warnings plugin.

@jenkins-infra-bot
Copy link
Author

@jenkins-infra-bot
Copy link
Author

[Originally related to: JENKINS-55744]

@dhruv070601
Copy link

fingbugs come under which plugin ?

@MarkEWaite
Copy link

fingbugs come under which plugin ?

What was "findbugs" is now "spotbugs" and is included in the Warnings plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants