Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR not getting built #3977

Closed
jglick opened this issue Mar 6, 2024 · 5 comments
Closed

PR not getting built #3977

jglick opened this issue Mar 6, 2024 · 5 comments

Comments

@jglick
Copy link

jglick commented Mar 6, 2024

Service(s)

ci.jenkins.io

Summary

I filed jenkinsci/workflow-cps-plugin#865 but it is not listed in https://ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/view/change-requests/ and https://ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/indexing/events ends with

…
[Tue Mar 05 14:52:49 UTC 2024] Pull request #817 updated in repository jenkinsci/workflow-cps-plugin UPDATED event from 140.82.115.46 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Tue Mar 05 14:52:43 UTC 2024 processed in 0.67 sec
[Tue Mar 05 14:52:49 UTC 2024] Received Pull request #817 updated in repository jenkinsci/workflow-cps-plugin UPDATED event from 140.82.115.80 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Tue Mar 05 14:52:44 UTC 2024
14:52:49 Connecting to https://api.github.com/ using 74951/****** (ci.jenkins.io GitHub App (jenkinsci org))
Examining [jenkinsci/workflow-cps-plugin](https://github.com/jenkinsci/workflow-cps-plugin)

  Checking pull-requests...

  Getting remote pull request #817...

Missing webhooks? I hope there is some periodic branch indexing configured which corrects this.

Reproduction steps

No response

@jglick jglick added the triage Incoming issues that need review label Mar 6, 2024
@jglick
Copy link
Author

jglick commented Mar 6, 2024

https://ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/indexing/console started by @NotMyFault seems to have created the branch project. Not sure why the event was lost. Could be closed.

@NotMyFault
Copy link
Member

ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/indexing/console started by @NotMyFault seems to have created the branch project. Not sure why the event was lost. Could be closed.

Oh hey, I had a similar PR that wasn't picked up, I started by hand. ci.j was down earlier due to the upcoming security advisory, and I'd assume we filed a PR right in this timeframe.

@dduportal
Copy link
Contributor

ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/indexing/console started by @NotMyFault seems to have created the branch project. Not sure why the event was lost. Could be closed.

Oh hey, I had a similar PR that wasn't picked up, I started by hand. ci.j was down earlier due to the upcoming security advisory, and I'd assume we filed a PR right in this timeframe.

Absolutely, ci.jenkins.io was down when jenkinsci/workflow-cps-plugin#865 was opened. There is a "once a day" check (more often would start to take a toll on the Gh rate limit) which would have taken care of detecting the new PR immediately.

Could be a case to revive jenkins-infra/captain-hooks (to queue webhooks requests while a controller is down).

@dduportal dduportal removed the triage Incoming issues that need review label Mar 6, 2024
@dduportal dduportal added this to the infra-team-sync-2024-03-12 milestone Mar 6, 2024
@dduportal dduportal self-assigned this Mar 6, 2024
@dduportal
Copy link
Contributor

@jglick I see the PR was merged: can you confirm it is closeable or do you need us to provide more on this?

@jglick
Copy link
Author

jglick commented Mar 6, 2024

queue webhooks requests while a controller is down

That, or just rerun branch indexing for all repos after a restart. 🤔 Perhaps this should be an option built into branch-api?

@jglick jglick closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants