Request to Host Appcircle Testing Distribution plugin for jenkins #3955

guvenkaranfil · 2024-06-05T12:56:16Z

Repository URL

https://github.com/appcircleio/appcircle-testing-distribution-plugin

New Repository Name

appcircle-testing-distribution-plugin

Description

Appcircle Testing Distribution plugin is a unique way to upload your build artifacts to appcircleio mobile DevOps platform

GitHub users to have commit permission

@guvenkaranfil

Jenkins project users to have release permission

guvenkaranfil
appcircle

Issue tracker

GitHub issues

jenkins-cert-app · 2024-06-05T12:56:47Z

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

/audit-ok => the audit is complete, the hosting can continue 🎉.
/audit-skip => the audit is not necessary, the hosting can continue 🎉.
/audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.6)

github-actions · 2024-06-05T13:03:05Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.414.3</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.
⛔ Required: The parent pom version '4.80' should be at least '4.82' or higher.
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

jenkins-cert-app · 2024-06-05T13:06:55Z

The Jenkins Security Scan discovered 9 finding(s) 🔍.

Please follow the instructions below for every identified issues:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

AppcircleBuilder.java#156

Potential CSRF vulnerability: If DescriptorImpl#doCheckMessage connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#151

Potential CSRF vulnerability: If DescriptorImpl#doCheckProfileID connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#146

Potential CSRF vulnerability: If DescriptorImpl#doCheckAppPath connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#141

Potential CSRF vulnerability: If DescriptorImpl#doCheckAccessToken connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

AppcircleBuilder.java#156

Potential missing permission check in DescriptorImpl#doCheckMessage

AppcircleBuilder.java#151

Potential missing permission check in DescriptorImpl#doCheckProfileID

AppcircleBuilder.java#146

Potential missing permission check in DescriptorImpl#doCheckAppPath

AppcircleBuilder.java#141

Potential missing permission check in DescriptorImpl#doCheckAccessToken

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

AppcircleBuilder.java#27

Field should be reviewed whether it stores a password and is serialized to disk: accessToken

guvenkaranfil · 2024-06-05T14:38:58Z

/hosting re-check

github-actions · 2024-06-05T14:39:29Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

guvenkaranfil · 2024-06-05T14:58:19Z

/hosting re-check

github-actions · 2024-06-05T15:00:30Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

guvenkaranfil · 2024-06-05T15:04:12Z

Where do I need to add the Isegal user. I follow the links but could not found any settings for user adding.

guvenkaranfil · 2024-06-05T17:58:45Z

/hosting re-check

github-actions · 2024-06-05T17:59:13Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

guvenkaranfil · 2024-06-05T18:05:09Z

/hosting re-check

github-actions · 2024-06-05T18:05:38Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

lsegal · 2024-06-05T18:10:03Z

@guvenkaranfil I just logged in, please wait until the next hour to re-check this. Sorry about the delay.

guvenkaranfil · 2024-06-05T19:27:57Z

/hosting re-check

github-actions · 2024-06-05T19:28:22Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

lsegal · 2024-06-05T23:39:43Z

@guvenkaranfil I think you should be giving commit / release permissions to yourself, not me.

GitHub users to have commit permission

@guvenkaranfil 

Jenkins project users to have release permission

guvenkaranfil

guvenkaranfil · 2024-06-06T06:02:19Z

/hosting re-check

github-actions · 2024-06-06T06:02:29Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions · 2024-06-06T06:02:44Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

guvenkaranfil · 2024-06-06T10:54:19Z

/hosting re-check

github-actions · 2024-06-06T10:54:44Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @lsegal (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

guvenkaranfil · 2024-06-06T10:56:38Z

I've updated the "GitHub users to have commit permission" but still getting the same error. What should I do?

timja · 2024-06-06T11:06:37Z

That error is not the same, its just issuing warnings about the "Jenkins project users to have release permission" section now

guvenkaranfil · 2024-06-06T12:09:13Z

I see, Could you please guide me through how can i resolve it. I searched the docs and open the link provided in the comment but I could not understand how can i add it. Thank you so much

github-actions · 2024-06-06T12:10:45Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @guvenkaranfil (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @guvenkaranfil (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions · 2024-06-07T11:55:34Z

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

NotMyFault · 2024-06-08T17:25:12Z

Hey,

I took a brief look over your hosting request and have some feedback for you:

The plugin does not compile with mvn clean verify package
You forgot to add a pipeline step.
https://github.com/appcircleio/appcircle-testing-distribution-plugin/blob/9639a8b1a39615beea0bea2c26ef9eb002da353f/src/main/java/io/jenkins/plugins/ac/AppcircleBuilder.java#L40-L52 instead of attempting to install something in the working directory, which you shouldn't touch at all, rather work with the pipeline-npm plugin.
Remove all unused dependencies from your pom.

guvenkaranfil · 2024-06-10T17:32:29Z

Hey,

I have fixed the linter compile error. Now you should be building with the mvn clean verify package
I do not want to configure a pipeline right away if it possible 🤔 I will be publishing it manually
I deleted the function it was unnecessary.
I removed the initially added dependencies.

guvenkaranfil · 2024-06-10T18:44:19Z

/request-security-scan

jenkins-cert-app · 2024-06-10T18:55:52Z

The Jenkins Security Scan discovered 9 finding(s) 🔍.

Please follow the instructions below for every identified issues:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

AppcircleBuilder.java#143

Potential CSRF vulnerability: If DescriptorImpl#doCheckMessage connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#138

Potential CSRF vulnerability: If DescriptorImpl#doCheckProfileID connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#133

Potential CSRF vulnerability: If DescriptorImpl#doCheckAppPath connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

AppcircleBuilder.java#128

Potential CSRF vulnerability: If DescriptorImpl#doCheckAccessToken connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

AppcircleBuilder.java#143

Potential missing permission check in DescriptorImpl#doCheckMessage

AppcircleBuilder.java#138

Potential missing permission check in DescriptorImpl#doCheckProfileID

AppcircleBuilder.java#133

Potential missing permission check in DescriptorImpl#doCheckAppPath

AppcircleBuilder.java#128

Potential missing permission check in DescriptorImpl#doCheckAccessToken

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

AppcircleBuilder.java#27

Field should be reviewed whether it stores a password and is serialized to disk: accessToken

guvenkaranfil · 2024-06-11T15:15:01Z

@NotMyFault Did you find a chance to look the commented fixes 🤔

NotMyFault · 2024-06-11T19:12:28Z

Without addressing the outstanding security issues, we will not perform a secondary screening.

guvenkaranfil · 2024-06-12T21:48:50Z

/request-security-scan

guvenkaranfil · 2024-06-12T21:58:22Z

/request-security-scan

jenkins-cert-app · 2024-06-13T00:15:41Z

The Jenkins Security Scan discovered 3 finding(s) 🔍.

Please follow the instructions below for every identified issues:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing permission check

You can find detailed information about this finding here.

AppcircleBuilder.java#151

Potential missing permission check in DescriptorImpl#doCheckMessage

AppcircleBuilder.java#145

Potential missing permission check in DescriptorImpl#doCheckProfileID

AppcircleBuilder.java#139

Potential missing permission check in DescriptorImpl#doCheckAppPath

guvenkaranfil · 2024-06-13T12:41:12Z

/request-security-scan

guvenkaranfil · 2024-06-13T12:47:07Z

Without addressing the outstanding security issues, we will not perform a secondary screening.

Thank you for your comments. I believe I have fixed the security issues that came from scan. Could you please move forward the approval process

jenkins-cert-app · 2024-06-13T12:50:16Z

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

guvenkaranfil · 2024-06-13T14:29:53Z

Are there any other things do I need to do for hosting @NotMyFault

NotMyFault · 2024-06-15T12:25:35Z

Hey,

I do not want to configure a pipeline right away if it possible 🤔 I will be publishing it manually

Without adding a pipeline step, the plugin isn't useful for the majority of Jenkins users, given pipelines and folders are the de facto standard job type people choose when working with source code.

guvenkaranfil · 2024-06-21T13:03:39Z

You want me to add a step into readme for showcasing people who want to use the plugin right 🤔

Or do you mean with "pipeline" for distributing the plugin automatically when a PR merged

guvenkaranfil added the hosting-request Request to host a component in jenkinsci label Jun 5, 2024

jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Jun 5, 2024

github-actions bot added the needs-fix label Jun 5, 2024

jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Jun 5, 2024

github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Jun 7, 2024

jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Jun 10, 2024

jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Jun 10, 2024

jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Jun 13, 2024

jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Jun 13, 2024

jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Jun 13, 2024

jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Jun 13, 2024

Request to Host Appcircle Testing Distribution plugin for jenkins #3955

Request to Host Appcircle Testing Distribution plugin for jenkins #3955

Comments

guvenkaranfil commented Jun 5, 2024 • edited Loading

Repository URL

New Repository Name

Description

GitHub users to have commit permission

Jenkins project users to have release permission

Issue tracker

jenkins-cert-app commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

jenkins-cert-app commented Jun 5, 2024

Stapler: Missing POST/RequirePOST annotation

Stapler: Missing permission check

Jenkins: Plaintext password storage

guvenkaranfil commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

guvenkaranfil commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

guvenkaranfil commented Jun 5, 2024

guvenkaranfil commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

guvenkaranfil commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

lsegal commented Jun 5, 2024

guvenkaranfil commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

lsegal commented Jun 5, 2024

guvenkaranfil commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

guvenkaranfil commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

guvenkaranfil commented Jun 6, 2024

timja commented Jun 6, 2024

guvenkaranfil commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 7, 2024

NotMyFault commented Jun 8, 2024

guvenkaranfil commented Jun 10, 2024

guvenkaranfil commented Jun 10, 2024

jenkins-cert-app commented Jun 10, 2024

Stapler: Missing POST/RequirePOST annotation

Stapler: Missing permission check

Jenkins: Plaintext password storage

guvenkaranfil commented Jun 11, 2024

NotMyFault commented Jun 11, 2024

guvenkaranfil commented Jun 12, 2024

guvenkaranfil commented Jun 12, 2024

jenkins-cert-app commented Jun 13, 2024

Stapler: Missing permission check

guvenkaranfil commented Jun 13, 2024

guvenkaranfil commented Jun 13, 2024

jenkins-cert-app commented Jun 13, 2024

guvenkaranfil commented Jun 13, 2024 • edited Loading

NotMyFault commented Jun 15, 2024

guvenkaranfil commented Jun 21, 2024 • edited Loading

guvenkaranfil commented Jun 5, 2024 •

edited

Loading

guvenkaranfil commented Jun 13, 2024 •

edited

Loading

guvenkaranfil commented Jun 21, 2024 •

edited

Loading