Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrf cd enabled #3964

Merged
merged 2 commits into from
Jun 24, 2024
Merged

ctrf cd enabled #3964

merged 2 commits into from
Jun 24, 2024

Conversation

Ma11hewThomas
Copy link
Contributor

@Ma11hewThomas Ma11hewThomas commented Jun 7, 2024

Link to GitHub repository

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @username1
  • @username2

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I have mentioned an existing team member of the plugin or component team to approve this request.
    Options
Loading

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

pr-6

CD checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist CD checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I have provided a link to the pull request in my plugin, which enables CD according to the documentation.
    Options
Loading

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options
Loading

There are IRC Bot commands for it.

@Ma11hewThomas Ma11hewThomas requested a review from a team as a code owner June 7, 2024 22:51
@NotMyFault
Copy link
Member

You forgot to incrementalify your pom, take a look at the documentation on how to do that and link a corresponding PR reflecting the changes needed: https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config

@Ma11hewThomas
Copy link
Contributor Author

Thanks, added link to PR

@Ma11hewThomas
Copy link
Contributor Author

Hello @NotMyFault, is the PR OK?

@NotMyFault
Copy link
Member

yes

@Ma11hewThomas
Copy link
Contributor Author

Thanks @NotMyFault , I've merged the PR

@timja timja merged commit c61eb14 into jenkins-infra:master Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants