Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate performance-signature-dynatrace #531

Closed
wants to merge 2 commits into from
Closed

deprecate performance-signature-dynatrace #531

wants to merge 2 commits into from

Conversation

rpionke
Copy link
Contributor

@rpionke rpionke commented Jul 1, 2021

The product Dynatrace AppMon is deprecated since 31.03.2021: (https://www.dynatrace.com/support/doc/appmon/)
I also added the successor of Dynatrace AppMon: https://plugins.jenkins.io/performance-signature-dynatracesaas/

FFR:
image

@daniel-beck
Copy link
Contributor

Deprecations are better off in the dedicated resource file, there you can specify a URL explaining the deprecation: https://github.com/jenkins-infra/update-center2/blob/master/resources/deprecations.properties

@daniel-beck daniel-beck added the metadata This PR only changes metadata (suspensions, labels, etc.) label Jul 1, 2021
@rpionke
Copy link
Contributor Author

rpionke commented Jul 1, 2021

@daniel-beck thanks for the advise, i added the plugins in the deprecations.properties file

@daniel-beck daniel-beck self-requested a review July 1, 2021 10:57
@basil
Copy link
Contributor

basil commented May 18, 2022

Can this pull request be merged? I wasted a non-zero amount of time recently investigating potential Java 11 impact on performance-signature-dynatrace only to discover this PR and to realize that my effort was wasted because this plugin is deprecated. If this PR were to have been merged, I would have seen the deprecation warning and would not have wasted my time on it.

@zbynek
Copy link
Contributor

zbynek commented May 18, 2022

@basil since git.io was discontinued, this cannot be merged and the two links it adds need replacing anyway, new PR is #593
@rpionke for labels for the new plugin you can just add them as topics to your plugin's github repo, then you can change them later without creating PRs in this repo

@daniel-beck
Copy link
Contributor

Implemented in #593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata This PR only changes metadata (suspensions, labels, etc.)
Projects
None yet
4 participants