Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test coverage and tests! #16

Open
rawlingsj opened this issue Mar 17, 2020 · 4 comments
Open

add unit test coverage and tests! #16

rawlingsj opened this issue Mar 17, 2020 · 4 comments

Comments

@rawlingsj
Copy link
Contributor

rawlingsj commented Mar 17, 2020

When the slack bot was made open source it came with no tests from its original source and so is very hard to make changes, understand what is meant to happen or what may be incorrect.

We should add test coverage and unit / integration tests, at the time of creating this issue we've started to add some but there is a long way to go. Not sure when we can say this issue can be closed, maybe once we get 50% coverage or something?

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@rawlingsj
Copy link
Contributor Author

/remove-lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants