Add possibility to select osDisk SKU

[timja]

When using templates and managed disks, in Azure it is possible to define the osDisk type during creation (HDD, Standard_SSD, Premium_SSD).
It would great if one could define the type for each Azure Virtual Machine Template.

[JENKINS-55943] created by claasd

[timja]

Thanks, I have put this in backlog.

by jieshe

[timja]

Any updates? Any help needed? (I don't know the codebase, but I could try if it's similar to eg. osDiskSize)

by stefanscherer

[timja]

Stefan Scherer Feel free to create a PR. Some useful pages : https://docs.microsoft.com/en-us/azure/templates/microsoft.compute/2019-03-01/virtualmachines#OSDisk and https://docs.microsoft.com/en-us/azure/templates/microsoft.compute/2019-03-01/virtualmachines#ManagedDiskParameters.

by jieshe

[timja]

Thanks,

I searched through the codebase and I think this variable 

"storageAccountType": "Standard_LRS",

in https://github.com/jenkinsci/azure-vm-agents-plugin/blob/dev/src/main/resources/customImageTemplateWithManagedDisk.json#L15 doesn't get changed.

 

by stefanscherer

[timja]

I've also created GH-59752 which is about the same topic, having better disk performance for the OS disk. This would be even more interesting for us.

by stefanscherer

[timja]

The "storageAccountType" is changed dynamically at

azure-vm-agents-plugin/src/main/java/com/microsoft/azure/vmagent/AzureVMManagementServiceDelegate.java

Line 517 in 4a0960e

putVariableIfNotBlank(tmp, "storageAccountType", storageAccountType);

 . But it seems that not all the templates' OSdisk item has the "managedDisk" property. 

by jieshe

[timja]

Any updates on this, not really sure this is tied to storage account type.

I believe storage account type is related to the disk storage type?

On Azure if I navigate to the disk resource the storage types available are:
Standard_HDD
Standard_SSD
Premium_SSD
Ultra Disk

on the storage account type dropdown I can only see Standard_LRS and Premium LRS
maybe this setting is not related, but if not can you provide a way to select the storage type in the disk that will be attached to the VM?

Thanks in advance, great plugin overall

by one_random_dev

[timja]

This appears to already be available in the 'Storage Account Type' field

[timja]

Ah right looking at the last comment 'StandardSSD_LRS' is missing, ultra disk requires data disk which this plugin doesn't support