Merge pull request #46 from DevFactory/release/general-code-quality-f…

…ix-1 General code quality fix-1
jenkins-infra · Jun 15, 2016 · 4210a13 · 4210a13
2 parents 8e6bca8 + e691879
commit 4210a13
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/src/main/java/org/jvnet/hudson/update_center/DefaultMavenRepositoryBuilder.java b/src/main/java/org/jvnet/hudson/update_center/DefaultMavenRepositoryBuilder.java
@@ -26,6 +26,11 @@
 import java.net.URL;
 
 public class DefaultMavenRepositoryBuilder {
+
+    private DefaultMavenRepositoryBuilder () {
+
+    }
+
     public static MavenRepositoryImpl createStandardInstance() throws Exception {
         MavenRepositoryImpl instance = new MavenRepositoryImpl();
         instance.addRemoteRepository("public", new URL("http://repo.jenkins-ci.org/public/"));

diff --git a/src/main/java/org/jvnet/hudson/update_center/HPI.java b/src/main/java/org/jvnet/hudson/update_center/HPI.java
@@ -72,6 +72,7 @@ public String getBuiltBy() throws IOException {
      * @deprecated
      *      Most probably you should be using {@link #getRequiredJenkinsVersion()}
      */
+    @Deprecated
     public String getRequiredHudsonVersion() throws IOException {
         return getManifestAttributes().getValue("Hudson-Version");
     }

diff --git a/src/main/java/org/jvnet/hudson/update_center/Main.java b/src/main/java/org/jvnet/hudson/update_center/Main.java
@@ -132,7 +132,7 @@ public class Main {
     @Option(name="-skip-release-history",usage="Skip generation of release history")
     public boolean skipReleaseHistory;
 
-    public Signer signer = new Signer();
+    private Signer signer = new Signer();
 
     public static final String EOL = System.getProperty("line.separator");
 

diff --git a/src/main/java/org/jvnet/hudson/update_center/MavenRepositoryImpl.java b/src/main/java/org/jvnet/hudson/update_center/MavenRepositoryImpl.java
@@ -253,8 +253,10 @@ public Collection<PluginHistory> listHudsonPlugins() throws PlexusContainerExcep
             }
 
             PluginHistory p = plugins.get(a.artifactId);
-            if (p==null)
-                plugins.put(a.artifactId, p=new PluginHistory(a.artifactId));
+            if (p==null) {
+                p=new PluginHistory(a.artifactId);
+                plugins.put(a.artifactId, p);
+            }
             p.addArtifact(createHpiArtifact(a, p));
             p.groupId.add(a.groupId);
         }