Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the script-security 1310.vf24a_dfce068b_ block #2805

Closed
MarkEWaite opened this issue Jan 6, 2024 · 1 comment · Fixed by #2817
Closed

Remove the script-security 1310.vf24a_dfce068b_ block #2805

MarkEWaite opened this issue Jan 6, 2024 · 1 comment · Fixed by #2817
Assignees
Labels
bug Something isn't working

Comments

@MarkEWaite
Copy link
Contributor

Jenkins and plugins versions report

Test failure can be seen with script security 1310.vf24a_dfce068b_:

LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

  1. Run the test with script security plugin 1310.x and this command:
LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh

Expected Results

Once a test with a more recent release of script-security is passing, then the script-security exclusion in the .github/dependabot.yml file should be removed.

Actual Results

Test fails unexpectedly

Anything else?

I've asked for help from @jglick in jenkinsci/script-security-plugin#552 (comment)

Are you interested in contributing a fix?

No response

@MarkEWaite MarkEWaite added the bug Something isn't working label Jan 6, 2024
@jglick jglick self-assigned this Jan 8, 2024
@jglick
Copy link
Member

jglick commented Jan 8, 2024

org.jvnet.hudson.test.RealJenkinsRule$StepException: Remote step threw an exception: jenkins.RestartRequiredException
	at org.jvnet.hudson.test.RealJenkinsRule.runRemotely(RealJenkinsRule.java:916)
	at org.jvnet.hudson.test.RealJenkinsRule.then(RealJenkinsRule.java:661)
	at org.jvnet.hudson.test.RealJenkinsRule.then(RealJenkinsRule.java:652)
	at org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApprovalLoadingTest.dynamicLoading(ScriptApprovalLoadingTest.java:42)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jvnet.hudson.test.RealJenkinsRule$1.evaluate(RealJenkinsRule.java:488)
Caused by: jenkins.RestartRequiredException
	at hudson.PluginManager.dynamicLoad(PluginManager.java:922)
	at hudson.PluginManager.dynamicLoad(PluginManager.java:892)
	at org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApprovalLoadingTest._dynamicLoading2(ScriptApprovalLoadingTest.java:54)

I think this is a PCT-only issue. Have to think about how to simply skip this test in PCT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants