Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support actions in publishChecks Step #85

Merged
merged 12 commits into from
Feb 21, 2021
Merged

Conversation

XiongKezhi
Copy link
Contributor

Solve issue: #74

@XiongKezhi XiongKezhi added the enhancement New feature or request label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #85 (76fc732) into master (24dcafe) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     86.82%   87.21%   +0.38%     
- Complexity      140      142       +2     
============================================
  Files            16       16              
  Lines           630      649      +19     
  Branches         49       49              
============================================
+ Hits            547      566      +19     
  Misses           65       65              
  Partials         18       18              
Impacted Files Coverage Δ Complexity Δ
...va/io/jenkins/plugins/checks/api/ChecksAction.java 100.00% <100.00%> (ø) 5.00 <1.00> (ø)
...enkins/plugins/checks/steps/PublishChecksStep.java 90.47% <100.00%> (+2.78%) 19.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dcafe...05e909c. Read the comment docs.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't there be some docs updates? or help file updates?

@timja
Copy link
Member

timja commented Feb 21, 2021

Can you try avoid force pushing while under review please, it makes it harder for me to tell what changed so I have to review from the beginning

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -118,6 +118,12 @@
<versionFormat>\d+\.\d+\.\d+</versionFormat>
<analysisConfiguration>
<revapi.ignore combine.children="append">
<item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed? I think you adjusted the implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, still needed, since we still add new field to PublishChecks step.

[INFO] API problems found.
[INFO] If you're using the semver-ignore extension, update your module's version to one compatible with the current changes (e.g. mvn package revapi:update-versions). If you want to explicitly ignore these changes or provide justifications for them, add the json snippets to your Revapi configuration for the "revapi.differences" extension.

{
  "code": "java.field.serialVersionUIDUnchanged",
  "old": "field io.jenkins.plugins.checks.steps.PublishChecksStep.serialVersionUID",
  "new": "field io.jenkins.plugins.checks.steps.PublishChecksStep.serialVersionUID",
  "serialVersionUID": "1",
  "justification": "ADD YOUR EXPLANATION FOR THE NECESSITY OF THIS CHANGE"
  /*  "package": "io.jenkins.plugins.checks.steps",
  "classQualifiedName": "io.jenkins.plugins.checks.steps.PublishChecksStep",
  "classSimpleName": "PublishChecksStep",
  "fieldName": "serialVersionUID",
  "elementKind": "field",
  "oldArchive": "io.jenkins.plugins:checks-api:hpi:1.5.0",
  "oldArchiveRole": "primary",
  "newArchive": "io.jenkins.plugins:checks-api:hpi:1.6.0-SNAPSHOT",
  "newArchiveRole": "primary",
  "breaksSemanticVersioning": "true",
  */
},

XiongKezhi and others added 2 commits February 21, 2021 17:23
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@XiongKezhi
Copy link
Contributor Author

Can you try avoid force pushing while under review please, it makes it harder for me to tell what changed so I have to review from the beginning

Sorry, my bad 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants