Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"slave" has been deprecated terminology since Jenkins 2 #121

Closed
rtyler opened this issue Feb 20, 2018 · 8 comments
Closed

"slave" has been deprecated terminology since Jenkins 2 #121

rtyler opened this issue Feb 20, 2018 · 8 comments

Comments

@rtyler
Copy link
Member

rtyler commented Feb 20, 2018

I noticed in the examples in the readme this snippet:

jenkins:
  securityRealm:
    (...)

  nodes:
    slave:
      name: "static-slave"
      remoteFS: "/home/jenkins"
      launcher: "jnlp"

Since this is early in the project, can usage of "slave" be replaced with "agent" in the API to match the existing terminology used since Jenkins 2.0?

It would be a big step backwards for such an important project to adopt the term.

@daniel-beck
Copy link
Member

Pretty sure I brought up the need for synonym/alternative term support with @ndeloof because of this. UI labels are often not what the internal class names are.

@oleg-nenashev
Copy link
Member

yup, it needs to be cleaned up.
FTR https://issues.jenkins-ci.org/browse/JENKINS-42816

@ndeloof
Copy link
Contributor

ndeloof commented Feb 20, 2018

@oleg-nenashev
Copy link
Member

Oh, these symbols are brilliant

@oleg-nenashev
Copy link
Member

@ndeloof Could you please create a ticket and add it to the https://issues.jenkins-ci.org/browse/JENKINS-42816 EPIC?

@oleg-nenashev
Copy link
Member

The core's fix has been integrated towards 2.109, JENKINS-49661 is a tracking number

@AnneTheAgile
Copy link

AnneTheAgile commented Mar 13, 2018

once core fix is done, then in this repo do we only need to change the doc strings 'slave' to 'agent' found via ; https://github.com/jenkinsci/configuration-as-code-plugin/search?utf8=%E2%9C%93&q=slave&type= ?

@ndeloof ndeloof closed this as completed Jul 19, 2018
@ndeloof
Copy link
Contributor

ndeloof commented Jul 19, 2018

plugin only reflect Java model and Symbol annotations it uses. We have no direct reference to "slave"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants