Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault secrets engine: Choose to abort config reloads if secrets cannot be resolved #1439

Open
1 task done
ninjaMog opened this issue Jul 22, 2020 · 0 comments
Open
1 task done
Labels
feature A PR that adds a feature - used by Release Drafter

Comments

@ninjaMog
Copy link

Your checklist for this issue

馃毃 Please review the guidelines for contributing to this repository.

  • Link to any upstream changes that might be required (for example Jenkins Core pull request)

Feature Request

When using the Vault secrets engine, if secret placeholders cannot be resolved (invalid secret / vault unavailable / access denied / other reasons) they are replaced with an empty string.

This can have catastrophic consequences, as a working Jenkins instance can suddenly have all it's credentials replaced with empty values if the vault server is not available (e.g. if there is a temporary connectivity issue)

This behaviour is stopping us adopting vault as our configuration as code secrets engine.

If we could enable a flag which aborted configuration reloads rather than continuing with the configuration update, this would resolve our problem.

Other suggestions most welcome!

@ninjaMog ninjaMog added the feature A PR that adds a feature - used by Release Drafter label Jul 22, 2020
@ninjaMog ninjaMog changed the title Choose to abort config reloads if secrets cannot be resolved Vault secrets engine: Choose to abort config reloads if secrets cannot be resolved Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A PR that adds a feature - used by Release Drafter
Projects
None yet
Development

No branches or pull requests

1 participant