Plugins installation #175

ndeloof · 2018-04-23T13:46:24Z

This is implementation for jenkinsci/jep#59

declare required plugins in yaml file, as well as update site configuration
lock all transitive dependencies in a shrinkwrap file for reproducibility
install plugins if required then restart
apply plugin configuration before any other configuration
test case

a better implementation would require metadata for plugins' versions (not just latest) hosted by update-center

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

and get Dependencies from MANIFEST Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof · 2018-05-28T18:25:32Z

@carlossg fyi as you were asking for it

…fault update site Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ewelinawilkosz · 2018-05-29T08:38:53Z

so here is what I did:

I put pretested-integration:2.4.1 in yaml
Reload configuration -> works so well!
I change pretested-integration to 3.0.1 (latest version) in yaml
Reload configuration -> seems like it went ok, no restart happens automatically (that expected behavior?)
Checking the update center and I can see a button to Restart if no jobs are running - so I press it
End up with stacktrace below

java.io.IOException: Pretested Integration Plugin v3.0.1 failed to load.
 - workflow-aggregator v2.5 is missing. To fix, install v2.5 or later.
 - Matrix Project Plugin v1.7.1 is older than required. To fix, install v1.11 or later.
	at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:626)
	at hudson.PluginManager.dynamicLoad(PluginManager.java:864)
Caused: java.io.IOException: Failed to install pretested-integration plugin
	at hudson.PluginManager.dynamicLoad(PluginManager.java:874)
	at hudson.PluginManager.dynamicLoad(PluginManager.java:813)
	at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1889)
Caused: java.io.IOException: Failed to dynamically deploy this plugin
	at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1893)
	at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1651)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:110)
Caused: org.jenkinsci.plugins.casc.ConfiguratorException: Failed to download plugin pretested-integration:3.0.1
	at org.jenkinsci.plugins.casc.plugins.PluginManagerConfigurator.configure(PluginManagerConfigurator.java:172)
	at org.jenkinsci.plugins.casc.plugins.PluginManagerConfigurator.configure(PluginManagerConfigurator.java:48)
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:340)
Caused: org.jenkinsci.plugins.casc.ConfiguratorException: plugins: error configuring <plugins> with <plugins> configurator
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:346)
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:280)
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.configure(ConfigurationAsCode.java:253)
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.configure(ConfigurationAsCode.java:156)
	at org.jenkinsci.plugins.casc.ConfigurationAsCode.init(ConfigurationAsCode.java:135)
Caused: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:104)
Caused: java.lang.Error
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:110)
	at hudson.init.TaskMethodFinder$TaskImpl.run(TaskMethodFinder.java:175)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:1090)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused: org.jvnet.hudson.reactor.ReactorException
	at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:269)
	at jenkins.InitReactorRunner.run(InitReactorRunner.java:47)
	at jenkins.model.Jenkins.executeReactor(Jenkins.java:1124)
	at jenkins.model.Jenkins.<init>(Jenkins.java:929)
	at hudson.model.Hudson.<init>(Hudson.java:86)
	at hudson.model.Hudson.<init>(Hudson.java:82)
	at hudson.WebAppMain$3.run(WebAppMain.java:235)
Caused: hudson.util.HudsonFailedToLoad
	at hudson.WebAppMain$3.run(WebAppMain.java:252)

shouldn't it install/update required plugins?

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

jetersen

LGTM

jetersen · 2018-05-29T09:12:44Z

src/main/java/org/jenkinsci/plugins/casc/plugins/PluginManagerConfigurator.java

+        return mapping;
+    }
+
+}


Missing newline

jetersen · 2018-05-29T09:13:07Z

.gitignore

+/jenkins.yaml
+plugins.txt


Missing newline

jetersen · 2018-05-29T09:13:42Z

src/test/java/org/jenkinsci/plugins/casc/PluginManagerConfiguratorTest.java

+    @ConfiguredWithCode("PluginManagerConfiguratorTest.yml")
+    public void testInstallPlugins() {
+        final Plugin chucknorris = j.jenkins.getPlugin("chucknorris");
+        assertNotNull(chucknorris);


…quirements Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ewelinawilkosz · 2018-05-30T06:41:42Z

basic tests I performed passed, I'm merging and hope for more feedback from users once I release new version (right after I merge)

ndeloof requested review from MadsNielsen and ewelinawilkosz April 23, 2018 13:46

ndeloof changed the title ~~[WiP] Plugins installation~~ Plugins installation Apr 24, 2018

ndeloof mentioned this pull request Apr 27, 2018

Try to support installation of specific versions of plugins #104

Closed

ndeloof changed the title ~~Plugins installation~~ [Blocked] Plugins installation May 7, 2018

ndeloof added 10 commits May 28, 2018 09:03

Support plugin installation

6905d28

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

rely on a shrink-wrap file for reproducibility

7e7475a

test-case to cover plugin installation

9b09997

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

adjust to recent API changes

586f19e

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

I hate you so much findbugs

35d10b7

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

fail CasC on missing plugin

faeeefc

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

use api's ConfiguratorException to report plugin issues

7d2529c

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

configure root element by Configurator order

983aeba

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

rely on DownloadService.signatureCheck

3967b72

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

prefer plugins.txt for consistency with docker image

9c972a5

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof changed the title ~~[Blocked] Plugins installation~~ Plugins installation May 28, 2018

ndeloof added 7 commits May 28, 2018 18:36

Install plugin by baking minimal plugin metadata

20cf9fa

and get Dependencies from MANIFEST Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

use dynamic installation

5e01776

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Detect requirement to restart

c233106

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

let's make findbugs happy

aa5d13c

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

deploy with CorrelationId is Restricted

17d5606

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

export current pluginManager config to yaml

70a5183

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

null check

5572356

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof added 4 commits May 29, 2018 09:46

Support 'artifact:version@site' notation for plugins not hosted by de…

eddc6c6

…fault update site Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Attempt to discover where a plugin has been installed from

9968213

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

site ID might not match any configured UpdateSite

7425a4d

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ignore plugins.txt

5d62d4b

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

force a restart on plugin upgrades

0b41e7c

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

jetersen approved these changes May 29, 2018

View reviewed changes

Detect shrinkwrap file is outdate as it doesn't match plugins.yaml re…

67203e2

…quirements Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ewelinawilkosz merged commit 65288ed into jenkinsci:master May 30, 2018

ndeloof deleted the plugins branch May 30, 2018 07:14

BlackJam44 mentioned this pull request Jul 5, 2019

Casc configuration with rebuilder, greenballs and Powershell plugins ? #937

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plugins installation #175

Plugins installation #175

ndeloof commented Apr 23, 2018 •

edited

ndeloof commented May 28, 2018

ewelinawilkosz commented May 29, 2018 •

edited

jetersen left a comment

jetersen May 29, 2018

jetersen May 29, 2018

jetersen May 29, 2018

MadsNielsen May 29, 2018

ewelinawilkosz commented May 30, 2018

		/jenkins.yaml
		plugins.txt

Plugins installation #175

Plugins installation #175

Conversation

ndeloof commented Apr 23, 2018 • edited

ndeloof commented May 28, 2018

ewelinawilkosz commented May 29, 2018 • edited

jetersen left a comment

Choose a reason for hiding this comment

jetersen May 29, 2018

Choose a reason for hiding this comment

jetersen May 29, 2018

Choose a reason for hiding this comment

jetersen May 29, 2018

Choose a reason for hiding this comment

MadsNielsen May 29, 2018

Choose a reason for hiding this comment

ewelinawilkosz commented May 30, 2018

ndeloof commented Apr 23, 2018 •

edited

ewelinawilkosz commented May 29, 2018 •

edited