Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total container cap of 0 reached, not provisioning #44

Closed
kristoflemmens opened this issue Jun 25, 2014 · 2 comments
Closed

Total container cap of 0 reached, not provisioning #44

kristoflemmens opened this issue Jun 25, 2014 · 2 comments

Comments

@kristoflemmens
Copy link

Setting for container cap says 0 (unlimited) but the plugin won't provision. When I set the container cap to 5 or something else the plugin starts with provisioning.

docker_screenshot

@kristoflemmens
Copy link
Author

So I found the problem myself by browsing the code. The container cap value has to be empty to have unlimited hosts. The documentation at https://wiki.jenkins-ci.org/display/JENKINS/Docker+Plugin says that 0 is unlimited

@jonathanperret
Copy link

Just hit upon this as well. What the documentation at https://wiki.jenkins-ci.org/display/JENKINS/Docker+Plugin says:

Container Cap: The maximum number of containers that this provider is allowed to have running, defaults to blank which disables the limit

used to be true, but changed in https://github.com/jenkinsci/docker-plugin/commit/bde53df15d84e746dba3a40fcaa050bf60260ab1 (by @KostyaSha) so that a blank entry is understood as zero, and sets the limit to zero. It's not clear whether the loss of that functionality was deliberate, so I suggest reopening this issue until someone with a broader view can decide whether to fix the documentation or the code.

edit: upon re-reading and noticing the date of this issue, I realized mine was different. I'll go and open another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants